Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching feature #4

Merged
merged 18 commits into from Mar 15, 2019
Merged

Switching feature #4

merged 18 commits into from Mar 15, 2019

Conversation

kalwalt
Copy link
Owner

@kalwalt kalwalt commented Mar 14, 2019

This is an important development feature for the template: you can choose the basename slug while switching to another language.

@@ -6,11 +6,11 @@ const En = (props) => {
<Icon viewBox="0 0 640 480" {...props}>
<defs>
<clipPath id="a">
<path fill-opacity=".7" d="M-85.3 0h682.6v512H-85.3z"/>
<path fillOpacity=".7" d="M-85.3 0h682.6v512H-85.3z"/>
Copy link
Owner Author

@kalwalt kalwalt Mar 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i get an error with these svg attributes: fill-opacity, clip-path, stroke-width, fill-rule, respectively to change in fillOpacity, clipPath, strokeWidth, fillRule.

@kalwalt
Copy link
Owner Author

kalwalt commented Mar 14, 2019

I want to change the Header ( the nav bar ) one for the English and the other one for the Italian menu. I will create a dictionary for the different version of the menu and for the titles of the menus, That is not only changing the path but also the title of the menu in the page.

@kalwalt
Copy link
Owner Author

kalwalt commented Mar 14, 2019

I discovered that in data/messages i can set up the titles of the menus with a react <FormattedMessage id='yourTitle' />. To do: the dictionaries for the path menus...

@kalwalt
Copy link
Owner Author

kalwalt commented Mar 15, 2019

the Select language switcher does not works always correctly, don't know why, this should be fixed...

@kalwalt
Copy link
Owner Author

kalwalt commented Mar 15, 2019

With the latest commits tags works again.

@kalwalt kalwalt self-assigned this Mar 15, 2019
@kalwalt kalwalt added the enhancement New feature or request label Mar 15, 2019
@kalwalt
Copy link
Owner Author

kalwalt commented Mar 15, 2019

I'm wondering if it is better to use Json format for the data (menuTree, articleTree...) or let as it is for now.

@kalwalt kalwalt merged commit f465f18 into dev Mar 15, 2019
@kalwalt kalwalt mentioned this pull request Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant