Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing #68 #74

Merged
merged 1 commit into from
Apr 12, 2019
Merged

Fixing #68 #74

merged 1 commit into from
Apr 12, 2019

Conversation

kalwalt
Copy link
Owner

@kalwalt kalwalt commented Apr 12, 2019

This fix issue #68 as said in the issue the problems happens only for th blog index page. The problem came because a wrong GraphQL query. See more in the comment below.

@kalwalt kalwalt added bug Something isn't working enhancement New feature or request code design labels Apr 12, 2019
@kalwalt kalwalt self-assigned this Apr 12, 2019
@kalwalt kalwalt changed the base branch from master to feature-Netlify-CMS April 12, 2019 18:24
@@ -55,7 +55,7 @@ BlogIndexPage.propTypes = {
}

export const pageQuery = graphql`
query BlogIndex
query BlogIndex($id: String!)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cause the issue: we receive the wrong id frontmatter for this reason!
See also below...

@@ -76,7 +76,7 @@ export const pageQuery = graphql`
}
}
}
markdownRemark
markdownRemark(id: { eq: $id })
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...linked to the comment above.

@kalwalt kalwalt added this to In progress in Adding Netlify CMS via automation Apr 12, 2019
@kalwalt
Copy link
Owner Author

kalwalt commented Apr 12, 2019

Well done, this can be merged!

@kalwalt kalwalt merged commit 82d9e61 into feature-Netlify-CMS Apr 12, 2019
Adding Netlify CMS automation moved this from In progress to Done Apr 12, 2019
@kalwalt kalwalt deleted the fixing-#68 branch April 12, 2019 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code design enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant