presence_reginfo: use parameter default_expires instead of 3600 constant

- GH #2996
kamailio · Jan 15, 2022 · 18e08d9 · 18e08d9
1 parent 001cf49
commit 18e08d9
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 4 deletions.
diff --git a/src/modules/presence_reginfo/add_events.c b/src/modules/presence_reginfo/add_events.c
@@ -39,7 +39,7 @@ int reginfo_add_events(void)
 
 	event.content_type.s = "application/reginfo+xml";
 	event.content_type.len = 23;
-	event.default_expires= 3600;
+	event.default_expires= pres_reginfo_default_expires;
 	event.type = PUBL_TYPE;
 	event.req_auth = 0;
 	event.evs_publ_handl = 0;

diff --git a/src/modules/presence_reginfo/doc/presence_reginfo_admin.xml b/src/modules/presence_reginfo/doc/presence_reginfo_admin.xml
@@ -64,6 +64,31 @@
 	  </section>
 	</section>
 
+    <section>
+		<title>Parameters</title>
+        <section id="presence_reginfo.p.default_expires">
+               <title><varname>default_expires</varname> (int)</title>
+               <para>
+               The default expires value used when missing from SUBSCRIBE
+               message (in seconds).
+               </para>
+               <para>
+               <emphasis>Default value is <quote>3600</quote>.
+               </emphasis>
+               </para>
+               <example>
+               <title>Set <varname>default_expires</varname> parameter</title>
+               <programlisting format="linespecific">
+        ...
+        modparam("presence_reginfo", "default_expires", 3600)
+        ...
+        </programlisting>
+            </example>
+        </section>
+
+	</section>
+
+
 	<section>
 		<title>Functions</title>
 		<para>

diff --git a/src/modules/presence_reginfo/presence_reginfo.c b/src/modules/presence_reginfo/presence_reginfo.c
@@ -46,14 +46,23 @@ static int mod_init(void);
 /* module variables */
 add_event_t pres_add_event;
 
+/* module parameters */
+unsigned int pres_reginfo_default_expires = 3600;
+
+/* module exported paramaters */
+static param_export_t params[] = {
+	{ "default_expires", INT_PARAM, &pres_reginfo_default_expires },
+	{0, 0, 0}
+};
+
 /* module exports */
 /* clang-format off */
 struct module_exports exports= {
     "presence_reginfo",	/* module name */
 	DEFAULT_DLFLAGS,	/* dlopen flags */
 	0,					/* exported functions */
-	0,					/* exported parameters */
-	0,					/* RPC method exports */
+	params,				/* exported parameters */
+	0,				    /* RPC method exports */
 	0,					/* exported pseudo-variables */
 	0,					/* response handling function */
 	mod_init,			/* module initialization function */

diff --git a/src/modules/presence_reginfo/presence_reginfo.h b/src/modules/presence_reginfo/presence_reginfo.h
@@ -25,5 +25,5 @@
 #define _PRES_REGINFO_H_
 
 extern add_event_t pres_add_event;
-
+extern unsigned int pres_reginfo_default_expires;
 #endif