Skip to content

Commit

Permalink
kamdbctl: remove not working db migrate command
Browse files Browse the repository at this point in the history 
- remove db migrate implementation in kamdbctl, .base, .mysql and .db_berkley files
- it was not working for mysql anyway, and not implemented for berkleydb
- this state was already documtend some weeks ago in commit 52a8def
  • Loading branch information
@henningw
henningw committed Mar 3, 2018
1 parent 0648043 commit 4d44756
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 211 deletions.
23 changes: 0 additions & 23 deletions utils/kamctl/kamdbctl
View file
Expand Up @@ -288,29 +288,6 @@ kamailio_pframework() #pars: <action>


case $1 in
migrate)
if [ "$USED_DBENGINE" != "mysql" ] ; then
merr "$USED_DBENGINE don't support migrate operation"
exit 1
fi
if [ $# -ne 3 ] ; then
merr "migrate requires 2 parameters: old and new database"
exit 1
fi
# create new database
minfo "Creating new Database $3...."
NO_USER_INIT="yes"
kamailio_create $3
if [ "$?" -ne 0 ] ; then
echo "migrate: creating new database failed"
exit 1
fi
# migrate data
minfo "Migrating data from $2 to $3...."
migrate_db $2 $3
minfo "Migration successfully completed."
exit 0;
;;
copy)
# copy database to some other name
if [ "$USED_DBENGINE" == "berkeley" -o "$USED_DBENGINE" == "dbtext" ] ; then
Expand Down
1 change: 0 additions & 1 deletion utils/kamctl/kamdbctl.base
View file
Expand Up @@ -97,7 +97,6 @@ usage: $COMMAND create <db name or db_path, optional> ...(creates a new database
$COMMAND backup <file> ...........................(dumps current database to file)
$COMMAND restore <file> ..........................(restores tables from a file)
$COMMAND copy <new_db> ...........................(creates a new db from an existing one)
$COMMAND migrate <old_db> <new_db> ...............(migrates DB - no longer maintained!)
$COMMAND presence ................................(adds the presence related tables)
$COMMAND extra ...................................(adds the extra tables)
$COMMAND dbuid ...................................(adds the uid tables)
Expand Down
21 changes: 0 additions & 21 deletions utils/kamctl/kamdbctl.db_berkeley
View file
Expand Up @@ -176,12 +176,6 @@ kamailio_berkeley() # parms: <op> <arg1> <arg2>
exit $?
;;

migrate)
shift
kamailio_migrate $1 $DB_PATH
exit $?
;;

import)
shift
kamailio_import $1 $DB_PATH
Expand Down Expand Up @@ -308,21 +302,6 @@ kamailio_export() # parms: <DUMP_DIR> [DB_PATH]
}


##
# MIGRATE (schema)
# Examine each plain-txt file in DUMP_DIR
# (Assumes that kamailio_export was already invoked)
#
# Migrate converts data from schema-old to schema-new in place.
#
# After this step is complete the IMPORT should be executed.
kamailio_migrate() # parms: <DUMP_DIR> [DB_PATH]
{
merr "db_berkeley migrate not implemented"
exit 1
}


##
# IMPORT existing plain-txt files from DUMP_DIR to DB_PATH
# eg. DUMP_DIR/version.txt --> DB_PATH/version
Expand Down
166 changes: 0 additions & 166 deletions utils/kamctl/kamdbctl.mysql
View file
Expand Up @@ -373,172 +373,6 @@ kamailio_add_tables () # params: <database name> <tables group name>
fi
} # end kamailio_add_tables

migrate_table () # 4 paremeters (dst_table, dst_cols, src_table, src_cols)
{
if [ $# -ne 4 ] ; then
merr "migrate_table function takes 4 params $@"
exit 1
fi

src_cols=`echo $4 | sed s/?/$3./g `

X=`sql_query "" "INSERT into $1 ($2) SELECT $src_cols from $3;" 2>&1`

if [ $? -ne 0 ] ; then
echo $X | $GREP "ERROR 1146" > /dev/null
if [ $? -eq 0 ] ; then
echo " -- Migrating $3 to $1.....SKIPPED (no source)"
return 0
fi
echo "ERROR: failed to migrate $3 to $1!!!"
echo -n "Skip it and continue (y/n)? "
read INPUT
if [ "$INPUT" = "y" ] || [ "$INPUT" = "Y" ]
then
return 0
fi

exit 1;
fi

minfo " -- Migrating $3 to $1.....OK"

}

migrate_db () # 2 parameters (src_db, dst_db)
{
if [ $# -ne 2 ] ; then
merr "migrate_db function takes 2 params"
exit 1
fi

dst_db=$2
src_db=$1

migrate_table ${dst_db}.acc \
"id,method,from_tag,to_tag,callid,sip_code,sip_reason,time" \
${src_db}.acc \
"?id,?method,?from_tag,?to_tag,?callid,?sip_code,?sip_reason,?time"

migrate_table ${dst_db}.missed_calls \
"id,method,from_tag,to_tag,callid,sip_code,sip_reason,time" \
${src_db}.missed_calls \
"?id,?method,?from_tag,?to_tag,?callid,?sip_code,?sip_reason,?time"

migrate_table ${dst_db}.aliases \
"id,username,domain,contact,expires,q,callid,cseq,last_modified,\
flags,cflags,user_agent" \
${src_db}.aliases \
"?id,?username,?domain,?contact,?expires,?q,?callid,?cseq,?last_modified,\
?flags,?cflags,?user_agent"

migrate_table ${dst_db}.dbaliases \
"id,alias_username,alias_domain,username,domain" \
${src_db}.dbaliases \
"?id,?alias_username,?alias_domain,?username,?domain"

migrate_table ${dst_db}.grp \
"id,username,domain,grp,last_modified" \
${src_db}.grp \
"?id,?username,?domain,?grp,?last_modified"

migrate_table ${dst_db}.re_grp \
"id,reg_exp,group_id" \
${src_db}.re_grp \
"?id,?reg_exp,?group_id"

migrate_table ${dst_db}.silo \
"id,src_addr,dst_addr,username,domain,inc_time,exp_time,snd_time,\
ctype,body" \
${src_db}.silo \
"?id,?src_addr,?dst_addr,?username,?domain,?inc_time,?exp_time,?snd_time,\
?ctype,?body"

migrate_table ${dst_db}.domain \
"id,domain,last_modified" \
${src_db}.domain \
"?id,?domain,?last_modified"

migrate_table ${dst_db}.uri \
"id,username,domain,uri_user,last_modified" \
${src_db}.uri \
"?id,?username,?domain,?uri_user,?last_modified"

migrate_table ${dst_db}.usr_preferences \
"id,uuid,username,domain,attribute,type,value,last_modified" \
${src_db}.usr_preferences \
"?id,?uuid,?username,?domain,?attribute,?type,?value,?last_modified"

migrate_table ${dst_db}.trusted \
"id,src_ip,proto,from_pattern,tag" \
${src_db}.trusted \
"?id,?src_ip,?proto,?from_pattern,?tag"

migrate_table ${dst_db}.address \
"id,grp,ip_addr,mask,port" \
${src_db}.address \
"?id,?grp,?ip_addr,?mask,?port"

migrate_table ${dst_db}.speed_dial \
"id,username,domain,sd_username,sd_domain,new_uri,\
fname,lname,description" \
${src_db}.speed_dial \
"?id,?username,?domain,?sd_username,?sd_domain,?new_uri,\
?fname,?lname,?description"

migrate_table ${dst_db}.gw \
"id,gw_name,grp_id,ip_addr,port,uri_scheme,transport,strip,prefix" \
${src_db}.gw \
"?id,?gw_name,?grp_id,?ip_addr,?port,?uri_scheme,?transport,?strip,?prefix"

migrate_table ${dst_db}.gw_grp \
"grp_id,grp_name" \
${src_db}.gw_grp \
"?grp_id,?grp_name"

migrate_table ${dst_db}.lcr \
"id,prefix,from_uri,grp_id,priority" \
${src_db}.lcr \
"?id,?prefix,?from_uri,?grp_id,?priority"

migrate_table ${dst_db}.pdt \
"id,sdomain,prefix,domain" \
${src_db}.pdt \
"?id,?sdomain,?prefix,?domain"

# migrate subscribers with no serweb support
migrate_table ${dst_db}.subscriber \
"id,username,domain,password,ha1,ha1b,rpid" \
${src_db}.subscriber \
"?id,?username,?domain,?password,?ha1,?ha1b,?rpid"

if [ "$HAS_EXTRA" = "yes" ] ; then
migrate_table ${dst_db}.cpl \
"id,username,domain,cpl_xml,cpl_bin" \
${src_db}.cpl \
"?id,?username,?domain,?cpl_xml,?cpl_bin"

migrate_table ${dst_db}.siptrace \
"id,date,callid,traced_user,msg,method,status,fromip,toip,\
fromtag,direction" \
${src_db}.siptrace \
"?id,?date,?callid,?traced_user,?msg,?method,?status,?fromip,?toip,\
?fromtag,?direction"

migrate_table ${dst_db}.imc_rooms \
"id,name,domain,flag" \
${src_db}.imc_rooms \
"?id,?name,?domain,?flag"

migrate_table ${dst_db}.imc_members \
"id,username,domain,room,flag" \
${src_db}.im_members \
"?id,?username,?domain,?room,?flag"
fi


} #end migrate_db()


export DBROOTPW
if [ "$#" -ne 0 ] && [ "$DBROOTPW" = "" ]; then
Expand Down

0 comments on commit 4d44756

Please sign in to comment.