Skip to content

Commit

Permalink
Makefile.defs: remove outdated OpenBSD logic
Browse files Browse the repository at this point in the history
  • Loading branch information
mslehto committed Feb 22, 2016
1 parent 996c1a5 commit 5e826dd
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 28 deletions.
16 changes: 0 additions & 16 deletions Makefile.defs
Expand Up @@ -1863,22 +1863,6 @@ ifeq ($(OS), openbsd)
YACC=yacc
# unfortunately pthread is needed for sigwait
LIBS= -lpthread
OPENBSD_IS_AOUT:= $(shell echo "$(OSREL)" | \
sed -e 's/^3\.[0-3][^0-9]*$$/yes/' |sed -e 's/^[0-2]\..*/yes/')
# exception: on sparc openbsd 3.2 is elf and not aout
ifeq ($(OSREL), 3.2)
ifeq ($(ARCH), sparc)
OPENBSD_IS_AOUT:=no
endif
ifeq ($(ARCH), sparc64)
OPENBSD_IS_AOUT:=no
endif
endif

ifeq ($(OPENBSD_IS_AOUT), yes)
C_DEFS+=-DDLSYM_PREFIX='"_"'
LDFLAGS= # openbsd ld doesn't like -O2 or -E
endif
endif # if opensd

ifeq ($(OS), netbsd)
Expand Down
18 changes: 6 additions & 12 deletions sr_module.c
Expand Up @@ -381,23 +381,18 @@ static int register_module(unsigned ver, union module_exports_u* e,
return ret;
}

#ifndef DLSYM_PREFIX
/* define it to null */
#define DLSYM_PREFIX
#endif

static inline int version_control(void *handle, char *path)
{
char **m_ver;
char **m_flags;
char* error;

m_ver=(char **)dlsym(handle, DLSYM_PREFIX "module_version");
m_ver=(char **)dlsym(handle, "module_version");
if ((error=(char *)dlerror())!=0) {
LM_ERR("no version info in module <%s>: %s\n", path, error);
return 0;
}
m_flags=(char **)dlsym(handle, DLSYM_PREFIX "module_flags");
m_flags=(char **)dlsym(handle, "module_flags");
if ((error=(char *)dlerror())!=0) {
LM_ERR("no compile flags info in module <%s>: %s\n", path, error);
return 0;
Expand Down Expand Up @@ -587,14 +582,13 @@ int load_module(char* mod_path)
if (!version_control(handle, path)) {
exit(-1);
}
mod_if_ver = (unsigned *)dlsym(handle,
DLSYM_PREFIX "module_interface_ver");
mod_if_ver = (unsigned *)dlsym(handle, "module_interface_ver");
if ( (error =(char*)dlerror())!=0 ){
LM_ERR("no module interface version in module <%s>\n", path );
goto error1;
}
/* launch register */
mr = (mod_register_function)dlsym(handle, DLSYM_PREFIX "mod_register");
mr = (mod_register_function)dlsym(handle, "mod_register");
if (((error =(char*)dlerror())==0) && mr) {
/* no error call it */
new_dlflags=dlflags;
Expand All @@ -612,7 +606,7 @@ int load_module(char* mod_path)
goto error;
}
}
exp = (union module_exports_u*)dlsym(handle, DLSYM_PREFIX "exports");
exp = (union module_exports_u*)dlsym(handle, "exports");
if(exp==NULL) {
/* 'exports' structure not found, look up for '_modulename_exports' */
mdir = strrchr(mod_path, '/');
Expand All @@ -624,7 +618,7 @@ int load_module(char* mod_path)
expref.len = strlen(expref.s);
if(expref.len>3 && strcmp(expref.s+expref.len-3, ".so")==0)
expref.len -= 3;
snprintf(exbuf, 62, DLSYM_PREFIX "_%.*s_exports", expref.len, expref.s);
snprintf(exbuf, 62, "_%.*s_exports", expref.len, expref.s);
exp = (union module_exports_u*)dlsym(handle, exbuf);
LM_DBG("looking up exports with name: %s\n", exbuf);
if ( (error =(char*)dlerror())!=0 ){
Expand Down

0 comments on commit 5e826dd

Please sign in to comment.