Skip to content

Commit

Permalink
Makefile.groups: remove kazoo group and move kazoo to rabbitmq
Browse files Browse the repository at this point in the history
  • Loading branch information
@linuxmaniac
linuxmaniac committed Jan 31, 2017
1 parent f503615 commit 71d42ee
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions src/Makefile.groups
View file
Expand Up @@ -172,9 +172,6 @@ mod_list_uuid=uuid
# - modules depending on ev library
mod_list_ev=evapi

# - modules depending on kazoo/rabbitmq
mod_list_kazoo=kazoo

# - modules depending on mongodb
mod_list_mongodb=db_mongodb ndb_mongodb

Expand All @@ -191,7 +188,7 @@ mod_list_systemd=log_systemd
mod_list_nsq=nsq

# - modules depending on librabbitmq library
mod_list_rabbitmq=rabbitmq
mod_list_rabbitmq=rabbitmq kazoo

# - all modules
mod_list_all=$(sort $(mod_list_basic) $(mod_list_extra) \
Expand All @@ -216,7 +213,7 @@ mod_list_all=$(sort $(mod_list_basic) $(mod_list_extra) \
$(mod_list_java) $(mod_list_dnssec) \
$(mod_list_sctp) $(mod_list_autheph) \
$(mod_list_gzcompress) $(mod_list_uuid) \
$(mod_list_ev) $(mod_list_kazoo) \
$(mod_list_ev) \
$(mod_list_mongodb) $(mod_list_cnxcc) \
$(mod_list_jansson) $(mod_list_geoip2) \
$(mod_list_erlang) $(mod_list_systemd) \
Expand Down Expand Up @@ -402,9 +399,6 @@ module_group_kuuid=$(mod_list_uuid)
# pkg libev modules
module_group_kev=$(mod_list_ev)

# pkg kazoo module
module_group_kkazoo=$(mod_list_kazoo)

# pkg mongodb modules
module_group_kmongodb=$(mod_list_mongodb)

Expand Down

6 comments on commit 71d42ee

@lazedo
Copy link
Contributor

@lazedo lazedo commented on 71d42ee Jan 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@linuxmaniac what's the reasoning for this ?

@linuxmaniac
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lazedo now we have rabbitmq group, lets use it. Makes no sense to me having kazoo group since both depends on librabbitmq library and rabbitmq name seems more generic than kazoo

@lazedo
Copy link
Contributor

@lazedo lazedo commented on 71d42ee Jan 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@linuxmaniac that would create problems when upgrading. also, why would kazoo require rabbitmq module to be installed ? everything that rabbitmq module does, kazoo module already does it, why is this module needed ?

@miconda
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see in the Makefile that kazoo depends on more libs, not only rabbitmq. Having it packaged alone is probably better.

@linuxmaniac
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lazedo @miconda reverted. But having more and more debs for single modules is not a good idea in my opinion. We should reach to a balance between dependences and number of module packages

@miconda
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a big fan of too many packages either (on the other hand I mainly install from git), but there are also cases when a module from a group has plenty of dependencies that one could think of why installing them if needing only another module from a group.

Is there a recommendation from Debian in similar cases? I was trying to analyze on this topic in the past and it seems that other apps/projects with modules have typically one package per module. I noticed that for PHP, with the typical modules I use there (php mysql, gd, curl, ...).

Maybe we should open an issue to debate the packaging. You can propose a grouping that you think it is the best and the others can contribute from there.

Please sign in to comment.