Skip to content

Commit

Permalink
pdb: use memcpy() for PDB_BUFTOSHORT macro
Browse files Browse the repository at this point in the history
- related to GH #2345

(cherry picked from commit be57be3)
  • Loading branch information
miconda authored and henningw committed Oct 2, 2020
1 parent b547889 commit 879fb53
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/modules/pdb/pdb.c
Expand Up @@ -190,7 +190,7 @@ static int pdb_msg_format_send(struct pdb_msg *msg,


/* two chars to short-int without caring of memory alignment in char buffer */
#define PDB_BUFTOSHORT(_b, _n) (((short int)_b[_n]) << 8) | (0x00ff & _b[_n+1])
#define PDB_BUFTOSHORT(_sv, _b, _n) memcpy(&(_sv), (char*)(_b) + (_n), sizeof(short int))

/*!
* \return 1 if query for the number succeded and the avp with the corresponding carrier id was set,
Expand Down Expand Up @@ -347,7 +347,7 @@ static int pdb_query(struct sip_msg *_msg, struct multiparam_t *_number, struct
case PDB_CODE_OK:
msg.bdy.payload[sizeof(struct pdb_bdy) - 1] = '\0';
if (strcmp(msg.bdy.payload, number.s) == 0) {
_id = PDB_BUFTOSHORT(msg.bdy.payload, reqlen); /* make gcc happy */
PDB_BUFTOSHORT(_id, msg.bdy.payload, reqlen); /* make gcc happy */
carrierid=ntohs(_id); /* convert to host byte order */
goto found;
}
Expand All @@ -370,7 +370,7 @@ static int pdb_query(struct sip_msg *_msg, struct multiparam_t *_number, struct
default:
buf[sizeof(struct pdb_msg) - 1] = '\0';
if (strncmp(buf, number.s, number.len) == 0) {
_id = PDB_BUFTOSHORT(buf, reqlen); /* make gcc happy */
PDB_BUFTOSHORT(_id, buf, reqlen); /* make gcc happy */
carrierid=ntohs(_id); /* convert to host byte order */
goto found;
}
Expand Down

0 comments on commit 879fb53

Please sign in to comment.