ldap: free in case of error cases

(cherry picked from commit 6d3a97d)
kamailio · Aug 30, 2017 · 9095551 · 9095551
1 parent fa2ff3a
commit 9095551
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/modules/ldap/ld_session.c b/src/modules/ldap/ld_session.c
@@ -62,6 +62,7 @@ int add_ld_session(char* _name, LDAP* _ldh, dictionary* _d)
 	new_lds->host_name = (char*)pkg_malloc(strlen(host_name)+1);
 	if (new_lds->host_name == NULL) {
 		LM_ERR("no memory\n");
+		pkg_free(new_lds);
 		return -1;
 	}
 	strcpy(new_lds->host_name, host_name);
@@ -117,6 +118,8 @@ int add_ld_session(char* _name, LDAP* _ldh, dictionary* _d)
 	new_lds->bind_dn = (char*)pkg_malloc(strlen(bind_dn)+1);
 	if (new_lds->bind_dn == NULL) {
 		LM_ERR("no memory\n");
+		pkg_free(new_lds->host_name);
+		pkg_free(new_lds);
 		return -1;
 	}
 	strcpy(new_lds->bind_dn, bind_dn);
@@ -129,6 +132,9 @@ int add_ld_session(char* _name, LDAP* _ldh, dictionary* _d)
 	new_lds->bind_pwd = (char*)pkg_malloc(strlen(bind_pwd)+1);
 	if (new_lds->bind_pwd == NULL) {
 		LM_ERR("no memory\n");
+		pkg_free(new_lds->bind_dn);
+		pkg_free(new_lds->host_name);
+		pkg_free(new_lds);
 		return -1;
 	}
 	strcpy(new_lds->bind_pwd, bind_pwd);

diff --git a/src/modules/ldap/ldap_mod.c b/src/modules/ldap/ldap_mod.c
@@ -447,6 +447,7 @@ static int ldap_result_check_fixup(void** param, int param_no)
 			if (pv_parse_format(&s, &(lp->check_str_elem_p)) < 0)
 			{
 				LM_ERR("pv_parse_format failed\n");
+				pkg_free(lp);
 				return E_OUT_OF_MEM;
 			}
 		}