kex: use snprintf() for rpc memory mod stats

- safer to ensure it doesn't overflow the target buffer
kamailio · Apr 16, 2019 · 99896b1 · 99896b1
1 parent 7e87138
commit 99896b1
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/modules/kex/mod_stats.c b/src/modules/kex/mod_stats.c
@@ -105,7 +105,7 @@ static int rpc_mod_print(rpc_t *rpc, void *ctx, const char *mname,
 
 	while (iter) {
 		if (strcmp(mname, iter->mname) == 0) {
-			sprintf(buff, "%s(%ld)", iter->func, iter->line);
+			snprintf(buff, 128, "%s(%ld)", iter->func, iter->line);
 			if (rpc->struct_add(stats_th, "d", buff, iter->size) < 0) {
 				rpc->fault(ctx, 500, "Internal error adding to struct rpc");
 				return -1;