modules/ims_registrar_pcscf: remove erroneous return

kamailio · Oct 28, 2015 · b71143a · b71143a
1 parent 7ddd6f7
commit b71143a
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/modules/ims_registrar_pcscf/service_routes.c b/modules/ims_registrar_pcscf/service_routes.c
@@ -308,7 +308,11 @@ int check_service_routes(struct sip_msg* _m, udomain_t* _d) {
 	/* Lock this record while working with the data: */
 	ul.lock_udomain(_d, &vb->host, port, proto);
 
-        pcontact_t * c = getContactP(_m, _d);
+	pcontact_t * c = getContactP(_m, _d);
+	if (!c) {
+		LM_DBG("no contact found in usrloc when checking for service route\n");
+		goto error;
+	}
 
 	/* Check the route-set: */
 	if (_m->route) {
@@ -386,7 +390,6 @@ int check_service_routes(struct sip_msg* _m, udomain_t* _d) {
 	/* Unlock domain */
 	ul.unlock_udomain(_d, &vb->host, port, proto);
 	return -1;
-    return 1;
 }
 
 static str route_start={"Route: <",8};