presence: test if event is dialog to avoid unnecessary xml parsing

(cherry picked from commit 6d0f899) (cherry picked from commit 4ffe23d)
kamailio · Apr 3, 2019 · d0d4ba7 · d0d4ba7
1 parent e01a1b7
commit d0d4ba7
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/src/modules/presence/presentity.c b/src/modules/presence/presentity.c
@@ -691,17 +691,18 @@ int update_presentity(struct sip_msg* msg, presentity_t* presentity, str* body,
 					goto error;
 				}
 			}
+			if (presentity->event->evp->type == EVENT_DIALOG) {
+				check_if_dialog(*body, &is_dialog, &dialog_id);
+				if (dialog_id) {
+					if (delete_presentity_if_dialog_id_exists(presentity, dialog_id) < 0) {
+						free(dialog_id);
+						dialog_id = NULL;
+						goto error;
+					}
 
-			check_if_dialog(*body, &is_dialog, &dialog_id);
-			if ( dialog_id ) {
-				if (delete_presentity_if_dialog_id_exists(presentity, dialog_id) < 0) {
 					free(dialog_id);
 					dialog_id = NULL;
-					goto error;
 				}
-
-				free(dialog_id);
-				dialog_id = NULL;
 			}
 			LM_DBG("inserting %d cols into table\n",n_query_cols);