Skip to content

Commit

Permalink
ims_registar_scscf: Fix subscr data handling in SAA
Browse files Browse the repository at this point in the history
During re-registration, in SAR, User-Data-Already-Available AVP is set.
However in SAA handling, error is generated if User-Data is not sent by
the HSS. This behavior is not correct.
For reference, check TS 29.228, Table 6.1.2.1.
  • Loading branch information
tdimitrov committed May 20, 2016
1 parent 0118338 commit f26152e
Showing 1 changed file with 14 additions and 9 deletions.
23 changes: 14 additions & 9 deletions modules/ims_registrar_scscf/cxdx_sar.c
Expand Up @@ -238,18 +238,23 @@ void async_cdp_callback(int is_timeout, void *param, AAAMessage *saa, long elaps
}

if (data->sar_assignment_type == AVP_IMS_SAR_REGISTRATION || data->sar_assignment_type == AVP_IMS_SAR_RE_REGISTRATION) {
if (build_p_associated_uri(s) != 0) {
LM_ERR("Unable to build p_associated_uri\n");
rerrno = R_SAR_FAILED;
goto error;
if (s) {
if (build_p_associated_uri(s) != 0) {
LM_ERR("Unable to build p_associated_uri\n");
rerrno = R_SAR_FAILED;
goto error;
}
}

}

//here we update the contacts and also build the new contact header for the 200 OK reply
if (update_contacts(t->uas.request, data->domain, &data->public_identity, data->sar_assignment_type, &s, &ccf1, &ccf2, &ecf1, &ecf2, &data->contact_header) <= 0) {
LM_ERR("Error processing REGISTER\n");
rerrno = R_SAR_FAILED;
goto error;
if (s) {
//here we update the contacts and also build the new contact header for the 200 OK reply
if (update_contacts_new(t->uas.request, data->domain, &data->public_identity, data->sar_assignment_type, &s, &ccf1, &ccf2, &ecf1, &ecf2, &data->contact_header) <= 0) {
LM_ERR("Error processing REGISTER\n");
rerrno = R_SAR_FAILED;
goto error;
}
}

if (data->contact_header) {
Expand Down

0 comments on commit f26152e

Please sign in to comment.