Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debian pkg missing dependency on docbook2x #1624

Closed
juha-h opened this issue Aug 23, 2018 · 7 comments
Closed

debian pkg missing dependency on docbook2x #1624

juha-h opened this issue Aug 23, 2018 · 7 comments
Assignees
Labels
bug pkg packaging related

Comments

@juha-h
Copy link
Contributor

juha-h commented Aug 23, 2018

Kamailio master build on Debian Stretch fails due to missing dependency on docbook2x. See https://lists.kamailio.org//pipermail/sr-dev/2018-August/047549.html for more info.

@juha-h juha-h added the bug label Aug 23, 2018
@linuxmaniac
Copy link
Member

@juha-h
Copy link
Contributor Author

juha-h commented Aug 23, 2018 via email

@linuxmaniac linuxmaniac self-assigned this Aug 24, 2018
@linuxmaniac linuxmaniac added pkg packaging related and removed bug labels Aug 24, 2018
@juha-h juha-h added the bug label Aug 31, 2018
@juha-h
Copy link
Contributor Author

juha-h commented Aug 31, 2018

This clearly is a bug. I don't understand why bug label was removed. Also, I my opinion this kind of error should not be ignored, but build should stop at it.

@miconda
Copy link
Member

miconda commented Aug 31, 2018

Overall this is not actually deb build specific issue, but something that happens during install, as I could spot during building and installing using git repo inside a docker container (for kamailio unit tests). I guess that was more an optional step added by SER devs in the past (in Kamailio we never had it), attempting to build man pages from docbooks for modules readmes.

I think this should be made optional properly. I do not think anyone was using manpage-style docs so far for modules and starting now to install/package them all makes no sense.

@juha-h
Copy link
Contributor Author

juha-h commented Aug 31, 2018 via email

miconda added a commit that referenced this issue Aug 31, 2018
- print an info message instead of ending up in execution error of
Makefile rule trying to generate man pages from xml files
- DOCBOOK var renamed to DOCBOOKMAN to be more suggestive for its
purpose
- related to GH #1624
@miconda
Copy link
Member

miconda commented Aug 31, 2018

Pushed a patch to catch when the tool from docbook to man page conversion is not available and just print an info message. I think this should do it for now, if one wants to start generating man pages, can do it by installing the tool.

I will close this issue and if one wants to package man pages for modules' readme, open a feature request. To my knowledge, so far they were never packaged. If some new issues after the patch, just reopen.

@miconda miconda closed this as completed Aug 31, 2018
@juha-h
Copy link
Contributor Author

juha-h commented Aug 31, 2018 via email

miconda added a commit that referenced this issue Sep 12, 2018
- print an info message instead of ending up in execution error of
Makefile rule trying to generate man pages from xml files
- DOCBOOK var renamed to DOCBOOKMAN to be more suggestive for its
purpose
- related to GH #1624

(cherry picked from commit 35aef07)
miconda added a commit that referenced this issue Apr 3, 2019
- print an info message instead of ending up in execution error of
Makefile rule trying to generate man pages from xml files
- DOCBOOK var renamed to DOCBOOKMAN to be more suggestive for its
purpose
- related to GH #1624

(cherry picked from commit 35aef07)
(cherry picked from commit 2ce4f03)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug pkg packaging related
Projects
None yet
Development

No branches or pull requests

3 participants