Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEMI record_route_preset requires 2 parameters instead of 1 #2171

Closed
WhiteyDude opened this issue Dec 9, 2019 · 1 comment
Closed

KEMI record_route_preset requires 2 parameters instead of 1 #2171

WhiteyDude opened this issue Dec 9, 2019 · 1 comment

Comments

@WhiteyDude
Copy link
Contributor

Description

Hi all!

It looks like in #2051 record_route_preset was exposed to KEMI, which is awesome (thank you @aalba6675 !). However the second parameter in this function should be optional (see https://kamailio.org/docs/modules/devel/modules/rr.html#rr.f.record_route_preset).

Troubleshooting

When using with a single parameter, the following error is thrown:

Dec 9 13:24:13 ip-10-0-0-1 /usr/local/sbin/kamailio[15828]: ERROR: app_ruby [app_ruby_api.c:499]: sr_kemi_ruby_exec_func_ex(): invalid str parameter type 2 (1)

Reproduction

(ruby Kemi)

# Failure
KSR::RR.record_route_preset('1.2.3.4:5060')
# Success
KSR::RR.record_route_preset('1.2.3.4:5060', '')
# Success
KSR::RR.record_route_preset('1.2.3.4:5060', '1.2.3.4:5060')

Additional Information

  • Kamailio Version - output of kamailio -v
version: kamailio 5.4.0-dev2 (x86_64/linux) 283e46-dirty
miconda added a commit that referenced this issue Dec 9, 2019
@miconda
rr: exported to kemi record_route_preset_one()
b05b089 
- the variant for record_route_preset() with one parameter
- GH #2171
@miconda
Copy link
Member

miconda commented Dec 9, 2019

Just exported in master branch the variant with one parameter:

KSR::RR.record_route_preset_one('1.2.3.4:5060')

Test and see if ok. It will be backported.

@miconda miconda closed this as completed Dec 9, 2019
miconda added a commit that referenced this issue Jan 8, 2020
@miconda
rr: exported to kemi record_route_preset_one()
72e0eb8 
- the variant for record_route_preset() with one parameter
- GH #2171

(cherry picked from commit b05b089)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miconda @WhiteyDude