Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtpengine: Unknown flag encountered: 'auto-bridge' #2301

Closed
sergey-safarov opened this issue Apr 26, 2020 · 6 comments
Closed

rtpengine: Unknown flag encountered: 'auto-bridge' #2301

sergey-safarov opened this issue Apr 26, 2020 · 6 comments

Comments

@sergey-safarov
Copy link
Member

sergey-safarov commented Apr 26, 2020

Description

According Kamailio rtpengine module supported auto-bridge flag. I added this flag in Kamailio config and get rtpengine warning

Unknown flag encountered: 'auto-bridge'

Then I make search in rtpengine commit history and cannot commits with auto-bridge string.
Think need remove 'auto-bridge flag from Kamailio rtpengine module.

@henningw
Copy link
Contributor

The flag is not documented at https://github.com/sipwise/rtpengine either.
Maybe the kamailio docs are outdated. The commit that introduced this parameter is 7c1b8e7 from 2014.

@ngvoice
Copy link
Member

ngvoice commented Apr 27, 2020

The docs state clearly:
"auto-bridge - this flag an alternative to the “internal” and “external” flags in order to do automatic bridging between IPv4 on the "internal network" and IPv6 on the "external network". Instead of explicitly instructing the RTP proxy to select a particular address family, the distinction is done by the given IP in the SDP body by the RTP proxy itself. Not supported by Sipwise rtpengine."

@ngvoice
Copy link
Member

ngvoice commented Apr 27, 2020

I've added the "auto-bridge" feature some years (!!) ago and when the RTPEngine protocol was updated, this feature was not added as well (and by now, I would also remove it). Likely, we should simply update the docs.
https://www.kamailio.org/docs/modules/devel/modules/rtpengine.html#rtpengine.f.rtpengine_offer

@sergey-safarov
Copy link
Member Author

As mentioned in rtpengine module doc

RFC6157 which suggest ICE for Dual-Stack implementations

So, think we can use ICE instead of auto-bridge

@miconda
Copy link
Member

miconda commented Apr 27, 2020

ICE requires client side support. And the ipv4-to-ipv6 bridge has anyhow the purpose to cover the cases when one device is on ipv4-only and the other in ipv6-only, so they cannot communicate directly anyhow, not matter they would support the other ipvX version.

As @ngvoice mentioned, should be removed, being inherited from rtpproxy module and not something available in rtpengine.

henningw added a commit that referenced this issue Apr 27, 2020
henningw added a commit that referenced this issue Apr 27, 2020
@henningw
Copy link
Contributor

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants