Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NATHELPER: fix_nated_sdp does not support a=rtcp headers #2459

Closed
oej opened this issue Aug 28, 2020 · 1 comment
Closed

NATHELPER: fix_nated_sdp does not support a=rtcp headers #2459

oej opened this issue Aug 28, 2020 · 1 comment
Labels
enhancement

Comments

@oej
Copy link
Member

oej commented Aug 28, 2020

Description

fix_nated_sdp() function with an IP address as argument supports modifying the media line and the connection line but not a=rtcp. It would be helpful if it did that line too.

Expected behavior

a=rtcp: IN ip4

Actual observed behavior

No modification
arsperger added a commit to arsperger/kamailio that referenced this issue Oct 5, 2020
@arsperger
nathelper: fix_nated_sdp added support for a=rtcp param RFC3605
c9a2bca 
- GH kamailio#2459
@arsperger arsperger mentioned this issue Oct 5, 2020
Merged
10 tasks
miconda pushed a commit that referenced this issue Oct 6, 2020
@arsperger @miconda
nathelper: fix_nated_sdp added support for a=rtcp param RFC3605
088738c 
- GH #2459
miconda pushed a commit that referenced this issue Oct 12, 2020
@arsperger @miconda
nathelper: fix_nated_sdp added support for a=rtcp param RFC3605
fd4dd36 
- GH #2459

(cherry picked from commit 088738c)
miconda pushed a commit that referenced this issue Oct 12, 2020
@arsperger @miconda
nathelper: fix_nated_sdp added support for a=rtcp param RFC3605
4c17c00 
- GH #2459

(cherry picked from commit 088738c)
(cherry picked from commit fd4dd36)
@miconda
Copy link
Member

miconda commented Nov 12, 2020

This should be implemented, with the commits referenced above.

@miconda miconda closed this as completed Nov 12, 2020
@dwagin dwagin mentioned this issue May 18, 2021
Closed
10 tasks
@arsperger arsperger mentioned this issue Jun 9, 2021
Merged
10 tasks
@dwagin dwagin mentioned this issue Jun 16, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oej @miconda