Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtp_media_server: declare extern dialog_list_mutex and tmb in header file #2522

Closed
amessina opened this issue Oct 20, 2020 · 6 comments
Closed

Comments

@amessina
Copy link
Contributor

amessina commented Oct 20, 2020

Similar to #2235

Better logs...

/usr/bin/ld: rtp_media_server.o:/builddir/build/BUILD/kamailio-5.4.1/src/modules/rtp_media_server/rtp_media_server.h:42: multiple definition of `dialog_list_mutex'; rms_dialog_info.o:/builddir/build/BUILD/kamailio-5.4.1/src/modules/rtp_media_server/rtp_media_server.h:42: first defined here
/usr/bin/ld: rtp_media_server.o:/builddir/build/BUILD/kamailio-5.4.1/src/modules/rtp_media_server/rtp_media_server.h:54: multiple definition of `tmb'; rms_dialog_info.o:/builddir/build/BUILD/kamailio-5.4.1/src/modules/rtp_media_server/rtp_media_server.h:54: first defined here
/usr/bin/ld: rms_media.o:/builddir/build/BUILD/kamailio-5.4.1/src/modules/rtp_media_server/rtp_media_server.h:42: multiple definition of `dialog_list_mutex'; rms_dialog_info.o:/builddir/build/BUILD/kamailio-5.4.1/src/modules/rtp_media_server/rtp_media_server.h:42: first defined here
/usr/bin/ld: rms_media.o:/builddir/build/BUILD/kamailio-5.4.1/src/modules/rtp_media_server/rtp_media_server.h:54: multiple definition of `tmb'; rms_dialog_info.o:/builddir/build/BUILD/kamailio-5.4.1/src/modules/rtp_media_server/rtp_media_server.h:54: first defined here
collect2: error: ld returned 1 exit status
miconda added a commit that referenced this issue Oct 21, 2020
@amessina
Copy link
Contributor Author

Thank you @miconda. The build is now possible for Fedora 32/33 x86_64.

@jchavanton
Copy link
Member

Thanks folks,

Very cool that you are able to build this module given the dependencies required, I was thinking it was not in the default module group.

@amessina
Copy link
Contributor Author

Thanks folks,

Very cool that you are able to build this module given the dependencies required, I was thinking it was not in the default module group.

I started building the Fedora packages here https://messinet.com/rpms/browser (bcunit, bctoolbox, ortp, and mediastreamer2) -- challenging to say the least and I probably need to update the packages to "include" more of the functionality from the underlying deps. Working through testing now and getting segfaults. Probably need to move testing to a separate simpler box.

@miconda
Copy link
Member

miconda commented Oct 21, 2020

Declaration were moved to .c files, but I reopen because the lock should be pointer and allocated in shared memory lock_alloc() to be properly used.

@miconda miconda reopened this Oct 21, 2020
@amessina
Copy link
Contributor Author

Thank you. @jchavanton, I'm going to open another issue where rms_bridge() doesn't seem to work properly.

miconda added a commit that referenced this issue Oct 23, 2020
- extern in .h files, GH #2522

(cherry picked from commit 128ba4f)
@jchavanton
Copy link
Member

This should fix the lock problem
#2529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants