-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localy generated transaction with dns failover and socket forcing #2987
Comments
Authors, can anyone take this? Initialy problem appears from anycast configuration, when Via header used to track original node. |
Failover in SIP needs SRV records. I would not expect DNS round robin to work with failover. Just load balancing. But if the choosen IP fails, that's a failure. |
Hi @oej ! Disagree about "I would not expect DNS round robin to work with failover. Just load balancing.", according to doc:
And if we comment out the strings which modify Via hiader in the scenario above:
We have the following signaling exchange: If uncomment any of the statement which modify Via then error appear as described in the first post . |
Hopefully this if fixed by commit 0ed1282 . Testing and feedback would be appreciated and in case all is ok, then it will backported. In case there are still problems, reopen. |
Hi @miconda ! Ths ! |
Hi @miconda ! I checked this commit, now it works, there are no errors in the log, except for one - there are no extra attributes in the second branch in the Via header,
|
Do i need to reopen issue ? |
Description
DNS failover do not wok for localy generated transaction when script forcing socket
or sets Via parameters with corex via_add_srvid/via_add_xavp_params, in log appear the errors:
Reproduction
Config stripped for localize problem:
disparcher list have only one target:
110 sip:192.168.122.131:5060;transport=udp 0 1
The scenario is simple - dispatcher try to ping target via proxy, config have two "A" records in cache,
all work as expected until tm:local-request route modify Via header by setting $fs or one of the
corex module functions which set flags FL_ADD_SRVID|FL_ADD_XAVP_VIA_PARAMS|FL_USE_XAVP_VIA_FIELDS,
tm in this case (after error as above) decline failover.
Debugging Data
transaction fail log:
I think that error somewhere in memory management when allocating/free structures for Via header modification
which is hard to debug, i have insert several debug output in uac.c in my case the problem fire after a call of function insert_tmcb:
In log i see:
insert_tmcb have shm_malloc fincion call in the beninig, after this call the content of uri structure is broken.
Additional Information
kamailio -v
The text was updated successfully, but these errors were encountered: