Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pua : default_expires parameter is not used in code #2994

Closed
adita76 opened this issue Jan 5, 2022 · 1 comment
Closed

pua : default_expires parameter is not used in code #2994

adita76 opened this issue Jan 5, 2022 · 1 comment

Comments

@adita76
Copy link

adita76 commented Jan 5, 2022

Description

pua : default_expires parameter is not functionally used in code

It is not used neither in pua module, nor in others pua_* modules.

Troubleshooting

Its presence is confusing if it does nothing, but it is described in documentation.

Possible Solutions

Can it be used as default expires for subscriptions related to pua events ? Otherwise it should be removed.
miconda added a commit that referenced this issue Jan 5, 2022
@miconda
pua: use parameter default_expires instead of 3600 constant
50a976f 
- GH #2994
@miconda
Copy link
Member

miconda commented Jan 5, 2022

Thanks for reporting! I pushed a commit for it (referenced above). If you can test and tell if works ok, then it can be backported.

@miconda miconda closed this as completed Jan 5, 2022
@adita76 adita76 mentioned this issue Jan 6, 2022
Closed
rhys-hanrahan pushed a commit to rhys-hanrahan/kamailio that referenced this issue Jan 21, 2022
@miconda @rhys-hanrahan
pua: use parameter default_expires instead of 3600 constant
f402a81 
- GH kamailio#2994
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miconda @adita76