Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong code for new mod param of pdt module #3626

Closed
doktorsip opened this issue Nov 2, 2023 · 1 comment
Closed

wrong code for new mod param of pdt module #3626

doktorsip opened this issue Nov 2, 2023 · 1 comment

Comments

@doktorsip
Copy link

doktorsip commented Nov 2, 2023

Description

This new code in pdttree.c is not correct for this new pdt mode, it just print's a debug log instead of error. The return value should be 0 instead of -1 in case _pdt_mode is 1 otherwise it will still not start.

if(_pdt_mode & 1) {
			LM_DBG("prefix already allocated [%.*s/[%.*s] - ignoring\n",
					sp->len, sp->s, sd->len, sd->s);
			return -1;
		} else {
			LM_ERR("prefix already allocated [%.*s/[%.*s]\n", sp->len, sp->s,
					sd->len, sd->s);
			return -1;
		}

Troubleshooting

Reproduction

Debugging Data

Log Messages

SIP Traffic

Possible Solutions

Additional Information

  • Operating System:
@miconda
Copy link
Member

miconda commented Nov 2, 2023

Thanks for spotting it. Fixed.

@miconda miconda closed this as completed Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants