Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialog module: dialog in 5 state is not removed #545

Closed
snen opened this issue Mar 14, 2016 · 9 comments
Closed

dialog module: dialog in 5 state is not removed #545

snen opened this issue Mar 14, 2016 · 9 comments

Comments

@snen
Copy link
Contributor

snen commented Mar 14, 2016

in v4.2
i made missconfiguration in kamailio.cfg, so kamailio send INVITE to itself:
INVITE request: endpoint -> kamailio -> kamailio
sip 407: kamailio -> kamailio -> endpoint

alfter that, _dlg.profile_list _ return this dialog up to kamailio restart

            "h_entry":  1185,
            "h_id": 1433,
            "call-id":  "1372913901@192.168.5.52",
            "from_uri": "sip:000*094@xxxx:5068",
            "to_uri":   "sip:00018966@xxxxxx:5068",
            "state":    5,
            "start_ts": 0,
            "init_ts":  1457963062,
            "timeout":  0,
            "lifetime": 43200,
......................

@miconda
Copy link
Member

miconda commented Mar 15, 2016

What is the exact version you are running (kamailio -v)? There were some fixes in the minor releases in v4.2.x.

@snen
Copy link
Contributor Author

snen commented Mar 15, 2016

4.2.7 (the latest git)

@dragos-oancea
Copy link

Hi.
Not sure if related but I experimented this with dialog_ng , the command dlg2.list was showing some dialogs in "Deleted" state after several hours after the actual dialogs finished.
Dragos

@snen
Copy link
Contributor Author

snen commented Mar 15, 2016

as far as I know, in dialog module 5-state-dialiog have to be deleted up to "tm"."wt_timer" period.

miconda added a commit that referenced this issue Mar 18, 2016
- reported by Dmitri Savolainen, GH #545
@miconda
Copy link
Member

miconda commented Mar 18, 2016

The transaction is lost after restart -- I pushed a safety clean for aged terminated dialogs to deal with the case.

@miconda
Copy link
Member

miconda commented Mar 18, 2016

Following the comments on commit: I understood the issue appears is revealed after a restart, so this was a safety for such cases, because the transaction is not recovered afterwards. If the dialog will be destroyed when the response is received, then retransmitted messages won't be handled properly (e.g., uac module has some features relying on dialog module), that's the reason for destroying when transaction is destroyed.

@snen
Copy link
Contributor Author

snen commented Mar 18, 2016

Following the comments on commit:

sorry I did not write it here

I understood the issue appears is revealed after a restart

Without commit 23a3481: there are dialog in 5 state which alive while kamailio alive (deleted after kamailio restart )

If the dialog will be destroyed when the response is received, then retransmitted messages won't be
handled properly

So may be it is a good idea adding dialog status filter to "get_profile_size".

@miconda
Copy link
Member

miconda commented Mar 18, 2016

Not sure with 4.2, but in the latest version the dialog should be removed from profile immediately it gets to state terminated, not waiting for the dialog to be destroyed.

@snen
Copy link
Contributor Author

snen commented Mar 19, 2016

ok. thanks

@snen snen closed this as completed Mar 19, 2016
miconda added a commit that referenced this issue Mar 21, 2016
- reported by Dmitri Savolainen, GH #545

(cherry picked from commit 23a3481)
miconda added a commit that referenced this issue Jun 29, 2016
- reported by Dmitri Savolainen, GH #545

(cherry picked from commit 23a3481)
(cherry picked from commit 2219505)
miconda added a commit that referenced this issue Jul 4, 2016
- reported by Dmitri Savolainen, GH #545

(cherry picked from commit 23a3481)
(cherry picked from commit 2219505)
(cherry picked from commit 29b483f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants