Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evapi_relay not working in resumed transaction #644

Closed
qmphan opened this issue May 28, 2016 · 6 comments
Closed

evapi_relay not working in resumed transaction #644

qmphan opened this issue May 28, 2016 · 6 comments

Comments

@qmphan
Copy link
Contributor

qmphan commented May 28, 2016 •
edited

If evapi_relay is called from a resumed transaction (in an event route), it doesn't send anything:

route[my_route] {
evapi_relay("Blah blah blah"); # This sends nothing
}
...

event_route[evapi:message-received] {
....
t_continue("$var(tindex)", "$var(tlabel)", "my_route");
}
@qmphan qmphan mentioned this issue May 30, 2016
Closed
miconda added a commit that referenced this issue May 30, 2016
@miconda
tm: reset T_ASYNC_SUSPENDED flag at beginning of t_continue()
827ec4f 
- should allow doing t_suspend() inside the route executed by
  t_continue()
- related to GH #644 and #645
@miconda
Copy link
Member

miconda commented May 30, 2016

Pushed a patch (referred above) that relocates the resetting of T_ASYNC_SUSPENDED. Can you test and see the results? If all ok, it can be considered for backporting.

@qmphan
Copy link
Contributor Author

qmphan commented May 30, 2016 •
edited

It works!!! Thank you for the fix @miconda ! Please backport to 4.4.

@qmphan qmphan closed this as completed May 30, 2016
@qmphan qmphan reopened this May 30, 2016
@miconda
Copy link
Member

miconda commented May 31, 2016

@qmphan is it working or not? In #622 you say evapi doesn't work anymore.

@qmphan
Copy link
Contributor Author

qmphan commented May 31, 2016 •
edited

@miconda : The patch above (827ec4f) works great. The one in #622 (2d1a7e4) doesn't. So please only backport the 827ec4f to the 4.4 branch.
The issue #622 remains.

@miconda
Copy link
Member

miconda commented May 31, 2016

OK - confused as you closed then re-opened this issue. So this can be closed.

@miconda miconda closed this as completed May 31, 2016
@qmphan
Copy link
Contributor Author

qmphan commented May 31, 2016

Yeah, I closed it then I thought it should be left open as a reminder to backport :)

miconda added a commit that referenced this issue Jun 27, 2016
@miconda
tm: reset T_ASYNC_SUSPENDED flag at beginning of t_continue()
fbe8523 
- should allow doing t_suspend() inside the route executed by
  t_continue()
- related to GH #644 and #645

(cherry picked from commit 827ec4f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miconda @qmphan