Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.4.x TOPOS - bad sip message or missing Contact hdr on OPTIONS messages #715

Closed
StellaTeam opened this issue Jul 18, 2016 · 4 comments
Closed

Comments

@StellaTeam
Copy link

topos is complaining about missing contact, but on an OPTIONS message, contact is not mandatory

23(12470) ERROR: topos [tps_storage.c:305]: tps_storage_link_msg(): bad sip message or missing Contact hdr

So, should "OPTIONS" be added to the exceptions in the code or is there a way to stop storing OPTIONS messages informations?

miconda added a commit that referenced this issue Jul 19, 2016
@miconda
Copy link
Member

miconda commented Jul 19, 2016

Can you try with the patch referenced above and see if works fine for OPTIONS? If all ok, then I will backport.

@StellaTeam
Copy link
Author

The patch has worked.
Thank you!

@StellaTeam
Copy link
Author

I reopen this issue as the same happens on BYE requests.
BYE requests (according to my understanding of RFC - page 161) doesn't require Contact header.

Do you mind adding METHOD_BYE in the condition? (it seems that Contact is only mandatory on INVITEs).

@StellaTeam StellaTeam reopened this Aug 9, 2016
miconda added a commit that referenced this issue Aug 9, 2016
@miconda
Copy link
Member

miconda commented Aug 9, 2016

Pushed a patch to check only for INVITE. If the issue is still there, reopen.

@miconda miconda closed this as completed Aug 9, 2016
miconda added a commit that referenced this issue Sep 8, 2016
- reported by Daren Crew, GH #715

(cherry picked from commit ab27f98)
miconda added a commit that referenced this issue Sep 8, 2016
- follow up on GH #715

(cherry picked from commit a91ca63)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants