Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$T_reply_last returns current reply status instead of previous #735

Closed
gaaf opened this issue Aug 2, 2016 · 3 comments
Closed

$T_reply_last returns current reply status instead of previous #735

gaaf opened this issue Aug 2, 2016 · 3 comments

Comments

@gaaf
Copy link
Contributor

gaaf commented Aug 2, 2016

The PV $T_reply_last is supposed to return the previous reply status. Since commit b7c588d to fix #315 this PV returns the current reply status.

@miconda
Copy link
Member

miconda commented Aug 2, 2016

Thanks for reporting, I will analyze as I get a chance.

@miconda
Copy link
Member

miconda commented Aug 5, 2016

Looking at the code, it seems that the last reply is the one returned now -- the name is a bit misleading if it expects the previous reply. I think it needs a dedicated field in the structure if one needs to get access to previous reply code. I would also suggest to add an alias like $T(prev_reply) for more suggestive name and obsolete $T_reply_last over the time, or let the one like it is now and add $T(prev_reply) for prev reply code.

@miconda
Copy link
Member

miconda commented Oct 7, 2019

Closing as being too old and no interest for long time. If still wanted, just make a pull request.

@miconda miconda closed this as completed Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants