Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use_domain doesn't work on alias_db #826

Closed
khoegh opened this issue Oct 21, 2016 · 4 comments
Closed

use_domain doesn't work on alias_db #826

khoegh opened this issue Oct 21, 2016 · 4 comments

Comments

@khoegh
Copy link
Contributor

khoegh commented Oct 21, 2016

After commit a63f390 use_domain is broken.
The value from alias_db_use_domain/use_domain is used in alias_flags_fixup which isn't called unless a flag i set.

alias_db_lookup("table") doesn't work
alias_db_lookup("table", "r") does work.
The same is true for db_alias_find()

I broke it and don't know how to fix it, sorry.

miconda added a commit that referenced this issue Oct 21, 2016
@miconda
Copy link
Member

miconda commented Oct 21, 2016

I pushed a commit for lookup function. Can you try and see the results?

@khoegh
Copy link
Contributor Author

khoegh commented Oct 21, 2016

alias_db_lookup seems correct now.
I tested with and without use_domain=1 in combination with and without flags. (none, r, dr, ur)

alias_db_find is wrong when no flags are set.

@miconda
Copy link
Member

miconda commented Oct 21, 2016

It was only for lookup, now I pushed one for find as well. Re-open if there is any issue with the last patch.

@miconda miconda closed this as completed Oct 21, 2016
@khoegh
Copy link
Contributor Author

khoegh commented Oct 21, 2016

Thanks @miconda .
alias_db_find works as it should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants