implement pua.publish rpc command in order to get rid of mi interface #878

juha-h · 2016-12-02T08:43:06Z

There is currently no rpc version of mi pua_publish. I once tried to implement it, but was not successful:

http://lists.sip-router.org/pipermail/sr-dev/2014-November/026177.html

Perhaps someone else could complete the job.

-- Juha

juha-h · 2016-12-02T08:46:43Z

There was also another later thread related to my pua.publish effort:

http://lists.sip-router.org/pipermail/sr-dev/2014-December/026293.html

miconda · 2016-12-06T10:13:16Z

Can you add the module attached to the discussion in the first link to master branch? I see that the discussion got to a point when you wanted to try further. Once the new module is in master I can pick up on troubleshooting eventual crashes.

For the second link, the discussion ended in approving the change if all was ok. I didn't have the time to check if you did the commit, but if not, go ahead and do it.

juha-h · 2016-12-06T12:21:39Z

Daniel-Constantin Mierla writes:

Can you add the module attached to the discussion in the first link to master branch? I see that the discussion got to a point when you wanted to try further. Once the new module is in master I can pick up on troubleshooting eventual crashes. For the second link, the discussion ended in approving the change if all was ok. I didn't have the time to check if you did the commit, but if not, go ahead and do it.

My Internet access is currently too slow. I'll commit later this week.

…

-- JUha

juha-h · 2016-12-09T07:57:56Z

Added pua_rpc module. It is still work in progress:

failure message is not produced when callback is not executed due to an error
readme file is missing

miconda · 2016-12-09T08:49:33Z

Can you test, reproduce the crash and attach the gdb output for:

bt full
info locals
list

so I can have a starting point for troubleshooting with the current master branch?

juha-h · 2016-12-09T09:16:31Z

there is no crash. see my previous comment.

miconda · 2016-12-09T09:22:49Z

I am not getting the current state, because in the links to old messages in mailing list archives are some backtraces.

In your previous message you say it's work in progress, referring to some missing failure message (a log message or what kind of message?!?) and docs. Maybe you can provide more details whether it is an issue to investigate or not, and if yes, describe what it is.

juha-h · 2016-12-09T11:31:46Z

It was described as well as I could in the second thread:
http://lists.sip-router.org/pipermail/sr-dev/2014-December/026293.html
from message
http://lists.sip-router.org/pipermail/sr-dev/2014-December/026294.html
onwards.

miconda · 2016-12-09T11:39:45Z

@juha-h - I read the mailing list threads and it's hard to digest where you got stuck. You pointed a crash, but it seems it's no longer the case, you refer to a message, but you don't say what message, a.s.o.

In this way it's not easy for me to sort out your issue. That's why I asked to provide fresh details, to start the troubleshooting on actual data, with current master branch. If you keep me looping around, I don't see how I can help. Instead of just pointing back and forth for many times same resources, then saying some are not the last one to look at, I think it will save the time in both sides to just extract the relevant details where you know they are still causing the issue and put them here in the bug tracker.

juha-h · 2016-12-09T12:01:04Z

Daniel-Constantin Mierla writes:

In this way it's not easy for me to sort out your issue. That's why I asked to provide fresh details, to start the troubleshooting on actual data, with current master branch. If you keep me looping around, I don't see how I can help. Instead of just pointing back and forth for many times same resources, then saying some are not the last one to look at, I think it will save the time in both sides to just extract the relevant details where you know they are still causing the issue and put them here in the bug tracker.

I have not asked for help. I just mentioned on the mailing list that I was not able to get pua.publish working and told what the problem was. It is OK with me to keep on using the MI command.

…

-- Juha

miconda · 2016-12-09T12:05:34Z

You haven't told the last and actual problem -- that's the problem here.

You pointed to some links in the mailing list archive that have no longer valid content. Like the one to the backtrace. So what I asked is to describe the last and current existing problem, but you kept pointing to same links -- waisting time in looping. If that's hard to do, then I cannot help. I tried to digest the discussions in the links and it is not clear what the actual issue is.

juha-h · 2016-12-09T12:42:03Z

The issue is as explained in
http://lists.sip-router.org/pipermail/sr-dev/2014-December/026294.html
i.e. when pua module send_publish API function returns 418 to pua_rpc publish function,
rpc->fault(c, 500, "Wrong ETag"); call produces response document

HTTP/1.1 200 OK.
Via: SIP/2.0/TCP 127.0.0.1:52280.
Server: OpenXg SIP Proxy (4.3.0-0 (i386/linux)).
Content-Length: 108.
.
<?xml version="1.0"?>
<methodResponse>
<params>
<param>
<value></value>
</param>
</params>

when it should produce response document

HTTP/1.1 200 OK.
Via: SIP/2.0/TCP 127.0.0.1:52204.
Server: OpenXg SIP Proxy (4.3.0-0 (i386/linux)).
Content-Length: 151.
.
<?xml version="1.0"?>
<methodResponse>
<params>
<param>
<value><int>500</int>
<string>Wrong ETag</string>
</value>
</param>
</params>
</methodResponse>

juha-h · 2016-12-09T12:44:02Z

Looks like my browser of github destroyed the xml documents in the previous message.They are shown in the original message
http://lists.sip-router.org/pipermail/sr-dev/2014-December/026294.html

miconda · 2016-12-09T13:15:49Z

For the records: snippets of code/etc. can be enclosed in triple backticks to keep them in original and highlight as block example. I updated the previous comment to display properly the xml.

Formatting the text for github forms is documented at:

https://guides.github.com/features/mastering-markdown/

The link is also below each input form, behind the text "Styling with Markdown is supported".

juha-h · 2016-12-12T10:48:25Z

i tried again and had the same issue as in 2014, i.e., when this code is executed:

	if (ret == 418) {
 	        LM_INFO("Calling rpc->fault(c, 500, \"Wrong ETag\")\n");
		rpc->fault(c, 500, "Wrong ETag");
		rpc->delayed_ctx_close(dctx);
	}

empty xmlrpc reply is produced:

T 2016/12/12 12:40:03.779869 127.0.0.1:45690 -> 127.0.0.1:6060 [AP]
POST /RPC2 HTTP/1.0.
Host: 127.0.0.1.
Connection: close.
User-Agent: OpenSIPg XML_RPC Client.
Content-Type: text/xml.
Content-Length: 972.
.

##
T 2016/12/12 12:40:03.779940 127.0.0.1:45690 -> 127.0.0.1:6060 [AP]
<?xml version="1.0" ?>.
<methodCall>.
.<methodName>pua.publish</methodName>.
.<params>.
..<param>.
...<value>.
....<string>sip:jh@test.tutpro.com</string>.
...</value>.
..</param>.
..<param>.
...<value>.
....<string>7776000</string>.
...</value>.
..</param>.
..<param>.
...<value>.
....<string>message-summary</string>.
...</value>.
..</param>.
..<param>.
...<value>.
....<string>application/simple-message-summary</string>.
...</value>.
..</param>.
..<param>.
...<value>.
....<string>.</string>.
...</value>.
..</param>.
..<param>.
...<value>.
....<string>foo</string>.
...</value>.
..</param>.
..<param>.
...<value>.
....<string>sip:127.0.0.1:5080;transport=tcp</string>.
...</value>.
..</param>.
..<param>.
...<value>.
....<string>P-Flags: 0

</string>.
...</value>.
..</param>.
..<param>.
...<value>.
....<string>Messages-Waiting: no

Message-Account: sip:jh@vm.test.tutpro.com

Voice-Message: 0/1 (0/0)

</string>.
...</value>.
..</param>.
.</params>.
</methodCall>.

##
T 2016/12/12 12:40:03.781651 127.0.0.1:6060 -> 127.0.0.1:45690 [AP]
HTTP/1.0 200 OK.
Sia: SIP/2.0/TCP 127.0.0.1:45690.
Server: OpenSIPg SIP Proxy (5.0.0-b3 (x86_64/linux)).
Content-Length: 108.
.
<?xml version="1.0"?>
<methodResponse>
<params>
<param>
<value></value>
</param>
</params>
</methodResponse>

Everything works fine when pua_send_publish(&publ) returns a non-negative value.

juha-h · 2016-12-12T11:28:55Z

I added LM_INFO to xmlrpc.c:

static void rpc_fault(rpc_ctx_t* ctx, int code, char* fmt, ...)
{
	static char buf[REASON_BUF_LEN];
	va_list ap;

	ctx->reply.code = code;
	LM_INFO("rpc_fault called with code '%d'\n", code);

and got to syslog:

Dec 12 13:24:17 lohi /usr/bin/sip-proxy[20580]: INFO: pua_rpc [pua_rpc.c:280]: publish(): Calling rpc->fault(c, 500, "Wrong ETag")
Dec 12 13:24:17 lohi /usr/bin/sip-proxy[20580]: INFO: xmlrpc [xmlrpc.c:911]: rpc_fault(): rpc_fault called with code '500'

It shows that indeed xmlrpc_fault gets called, but it does not produce anything to xmlrpc response.

miconda · 2016-12-12T11:41:47Z

I didn't have time so far but it's in my plan for this week to play with it and figure out where is the problem.

- may fix the GH #878, reported by Juha Heinanen

miconda · 2016-12-12T17:36:50Z

Can you try with latest master? A small patch I pushed to xmlrpc module may be the solution, but I didn't have time to play with it yet. I got some rounds of symbol lookup conflicts while trying to troubleshoot on a macos that stuck me for a while (blaiming some compile flags) and I had to rename some symbols in pua_rpc to get me moved forward...

juha-h · 2016-12-12T23:25:43Z

Daniel-Constantin Mierla writes:

Can you try with latest master? A small patch I pushed to xmlrpc module may be the solution, but I didn't have time to play with it yet. I got some rounds of symbol lookup conflicts while trying to troubleshoot on a macos that stuck me for a while (blaiming some compile flags) and I had to rename some symbols in pua_rpc to get me moved forward...

It worked now! So the bug was not in pua_rpc, but in xmlrpc module. I'll do some more testing. Thanks,

…

-- Juha

miconda · 2016-12-13T08:14:44Z

Yes, the issue was in xmrpc -- the delayed context used also when sending publish failed was not initialized for just doing rpc fault -- it was done when building a response with rpc add.

juha-h · 2016-12-13T08:41:45Z

I'm closing this, since pua_rpc module now includes pua.publish. I'll open another one on pua.subscribe in case someone needs it.

- may fix the GH #878, reported by Juha Heinanen (cherry picked from commit 6b3ce63)

miconda added a commit that referenced this issue Dec 12, 2016

xmlrpc: init delayed context for rpc_fault()

6b3ce63

- may fix the GH #878, reported by Juha Heinanen

juha-h closed this as completed Dec 13, 2016

miconda added a commit that referenced this issue Jan 17, 2017

xmlrpc: init delayed context for rpc_fault()

9902d21

- may fix the GH #878, reported by Juha Heinanen (cherry picked from commit 6b3ce63)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

implement pua.publish rpc command in order to get rid of mi interface #878

implement pua.publish rpc command in order to get rid of mi interface #878

juha-h commented Dec 2, 2016

juha-h commented Dec 2, 2016

miconda commented Dec 6, 2016

juha-h commented Dec 6, 2016 via email

juha-h commented Dec 9, 2016

miconda commented Dec 9, 2016

juha-h commented Dec 9, 2016

miconda commented Dec 9, 2016

juha-h commented Dec 9, 2016

miconda commented Dec 9, 2016

juha-h commented Dec 9, 2016 via email

miconda commented Dec 9, 2016

juha-h commented Dec 9, 2016 •

edited by miconda

juha-h commented Dec 9, 2016

miconda commented Dec 9, 2016

juha-h commented Dec 12, 2016 •

edited by miconda

juha-h commented Dec 12, 2016 •

edited by miconda

miconda commented Dec 12, 2016

miconda commented Dec 12, 2016

juha-h commented Dec 12, 2016 via email

miconda commented Dec 13, 2016

juha-h commented Dec 13, 2016

implement pua.publish rpc command in order to get rid of mi interface #878

implement pua.publish rpc command in order to get rid of mi interface #878

Comments

juha-h commented Dec 2, 2016

juha-h commented Dec 2, 2016

miconda commented Dec 6, 2016

juha-h commented Dec 6, 2016 via email

juha-h commented Dec 9, 2016

miconda commented Dec 9, 2016

juha-h commented Dec 9, 2016

miconda commented Dec 9, 2016

juha-h commented Dec 9, 2016

miconda commented Dec 9, 2016

juha-h commented Dec 9, 2016 via email

miconda commented Dec 9, 2016

juha-h commented Dec 9, 2016 • edited by miconda

juha-h commented Dec 9, 2016

miconda commented Dec 9, 2016

juha-h commented Dec 12, 2016 • edited by miconda

juha-h commented Dec 12, 2016 • edited by miconda

miconda commented Dec 12, 2016

miconda commented Dec 12, 2016

juha-h commented Dec 12, 2016 via email

miconda commented Dec 13, 2016

juha-h commented Dec 13, 2016

juha-h commented Dec 9, 2016 •

edited by miconda

juha-h commented Dec 12, 2016 •

edited by miconda

juha-h commented Dec 12, 2016 •

edited by miconda