Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

presence: error "transaction already started" when updating watcher records on db-only mode #960

Closed
linuxmaniac opened this issue Jan 31, 2017 · 1 comment
Closed

presence: error "transaction already started" when updating watcher records on db-only mode #960

linuxmaniac opened this issue Jan 31, 2017 · 1 comment

Comments

@linuxmaniac
Copy link
Member

We do have this presence module parameters:

modparam("presence", "subs_db_mode", 3)
modparam("presence", "publ_cache", 0)
modparam("presence", "db_table_lock_type", 0)
modparam("presence", "notifier_processes", 3)
modparam("presence", "send_fast_notify", 0)

And we are getting this errors several times per second

proxy[9056]: ERROR: db_mysql [km_dbase.c:602]: db_mysql_start_transaction(): transaction 
already started
proxy[9056]: ERROR: presence [notify.c:1365]: publ_notify_notifier(): in start_transaction
proxy[9056]: ERROR: presence [presentity.c:1132]: update_presentity(): updating watcher 
records
proxy[9056]: ERROR: presence [publish.c:462]: handle_publish(): when updating presentity

This logs are from kamailio 4.4.4 but I think the problem is in master too.

I do see that publ_notify_notifier() has a call to start_transaction()
https://github.com/kamailio/kamailio/blob/master/src/modules/presence/notify.c#L1366-L1373
but we are already inside a transaction either at
https://github.com/kamailio/kamailio/blob/master/src/modules/presence/presentity.c#L686-L693
or
https://github.com/kamailio/kamailio/blob/master/src/modules/presence/presentity.c#L735-L742
@linuxmaniac
Copy link
Member Author

is there any way to check if we are inside a transaction using srdb1?

linuxmaniac added a commit to torreviejawireless/kamailio that referenced this issue Jan 31, 2017
@linuxmaniac
presence: remove transaction creation from publ_notify_notifier() and…
fc934e5 
… mark_presentity_for_delete()

* publ_notify_notifier() and mark_presentity_for_delete() are
  called inside a already created transaction
* adding transaction handle for msg_presentity_clean()

fix kamailio#960
linuxmaniac added a commit to torreviejawireless/kamailio that referenced this issue Jan 31, 2017
@linuxmaniac
presence: remove transaction creation from publ_notify_notifier() and…
653fefc 
… mark_presentity_for_delete()

* publ_notify_notifier() and mark_presentity_for_delete() are
  called inside a already created transaction
* adding transaction handle for msg_presentity_clean()

fix kamailio#960
linuxmaniac added a commit that referenced this issue Feb 22, 2017
@linuxmaniac
presence: remove transaction creation from publ_notify_notifier() and…
4a41962 
… mark_presentity_for_delete()

* publ_notify_notifier() and mark_presentity_for_delete() are
  called inside a already created transaction
* adding transaction handle for msg_presentity_clean()

fix #960

(cherry picked from commit 6d157a4)
lbalaceanu pushed a commit to lbalaceanu/kamailio that referenced this issue Mar 16, 2017
@linuxmaniac @lbalaceanu
presence: remove transaction creation from publ_notify_notifier() and…
6436e61 
… mark_presentity_for_delete()

* publ_notify_notifier() and mark_presentity_for_delete() are
  called inside a already created transaction
* adding transaction handle for msg_presentity_clean()

fix kamailio#960
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@linuxmaniac