Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to Makefiles.def to support building on recent versions of Solaris #963

Closed
hunger1 opened this issue Feb 1, 2017 · 2 comments
Closed

Change to Makefiles.def to support building on recent versions of Solaris #963

hunger1 opened this issue Feb 1, 2017 · 2 comments

Comments

@hunger1
Copy link

hunger1 commented Feb 1, 2017 •
edited by miconda

Description

The version of yacc on Solaris is ancient and fails to process cfg.lex.

Reproduction

Run gmake

Possible Solutions

Based on kamailio-4.4.5, change Makefiles.defs to comment out "YACC=yacc" on line 1838 for the block beginning "ifeq ($(OS), solaris)" on line 1804.

$ diff -c Makefile.defs~ Makefile.defs
*** Makefile.defs~      Wed Jan 18 07:00:21 2017
--- Makefile.defs       Wed Feb  1 07:58:49 2017
***************
*** 1835,1841 ****
                #LDFLAGS=-g $(PROFILE)
                #MOD_LDFLAGS=-g -G
        endif
!       YACC=yacc

  ifeq ($(CC_NAME), suncc)
        LIBS= -ldl -lresolv
--- 1835,1841 ----
                #LDFLAGS=-g $(PROFILE)
                #MOD_LDFLAGS=-g -G
        endif
! #     YACC=yacc

  ifeq ($(CC_NAME), suncc)
        LIBS= -ldl -lresolv
  • Operating System:

Solaris 11.3
@miconda
Copy link
Member

miconda commented Feb 1, 2017

Could you make a pull request with this change for master branch? In this way the travis-ci makes sure no build is broken and it is easier merge once reviewing the change.

miconda added a commit that referenced this issue Feb 8, 2017
@miconda
Makefile.defs: don't enforce yacc on solaris
47590dd 
- it's old and fails to parse the cfg
- reported by GH #963
@miconda
Copy link
Member

miconda commented Feb 8, 2017

Committed to master.

@miconda miconda closed this as completed Feb 8, 2017
lbalaceanu pushed a commit to lbalaceanu/kamailio that referenced this issue Mar 16, 2017
@miconda @lbalaceanu
Makefile.defs: don't enforce yacc on solaris
384bb2d 
- it's old and fails to parse the cfg
- reported by GH kamailio#963
miconda added a commit that referenced this issue Jun 13, 2017
@miconda
Makefile.defs: don't enforce yacc on solaris
4ab8484 
- it's old and fails to parse the cfg
- reported by GH #963

(cherry picked from commit 47590dd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miconda @hunger1