Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HEPv3 support to siptrace #1006

Merged
merged 4 commits into from Feb 23, 2017
Merged

Add HEPv3 support to siptrace #1006

merged 4 commits into from Feb 23, 2017

Conversation

giavac
Copy link
Contributor

@giavac giavac commented Feb 23, 2017

This PR allows kamailio to duplicate messages to Homer using HEPv3 [0].
An optional correlation ID (which can contain PVs) can be passed to sip_trace().

The packing macros in hep.h are authored by @camilleoudot and I've just used them.

An example of formats:

modparam("siptrace", "duplicate_uri", "sip:127.0.0.1:9062")
...
sip_trace("sip:127.0.0.1:9060", "123"); // duplicate URI + correlation ID
sip_trace("", "345"); // default URI + correlation ID
sip_trace("", "$fU-678"); // default URI + correlation ID with PVs
sip_trace(); // default URI + no correlation ID

[0] https://github.com/sipcapture/HEP/blob/master/docs/HEP3_rev12.pdf

@camilleoudot camilleoudot self-requested a review February 23, 2017 11:35
@miconda
Copy link
Member

miconda commented Feb 23, 2017

Thanks! Can be merged and backported to branch 5.0 as it fixes the compatibility with HEPv3.

Note: I invited @giavac to join developers team, given his many contributions over the time

@giavac
Copy link
Contributor Author

giavac commented Feb 23, 2017

Thanks Daniel

@miconda
Copy link
Member

miconda commented Feb 23, 2017

@giavac welcome, thanks for all your contributions! Now you should be able to merge the PR by yourself and commit directly (if you want that instead of PR -- that should be more handy for backports at least).

@giavac
Copy link
Contributor Author

giavac commented Feb 23, 2017

I'll leave some time for @adubovikov to read/review, then I'll proceed with merge and backport.

@adubovikov
Copy link
Member

looks very good for me!

@giavac giavac merged commit 103e503 into kamailio:master Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants