db_text fixes & live query #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miconda
reviewed
Mar 4, 2017
src/modules/db_text/dbt_raw_query.c
Outdated
| @@ -117,15 +117,22 @@ int dbt_raw_query_select(db1_con_t* _h, str* _s, db1_res_t** _r) | |||
| result_cols = pkg_malloc(sizeof(db_key_t) * cols); | |||
| memset(result_cols, 0, sizeof(db_key_t) * cols); | |||
| for(n=0; n < cols; n++) { | |||
| result_cols[n] = &_tbc->colv[n]->name; | |||
| result_cols[n] = pkg_malloc(sizeof(str)); | |||
There was a problem hiding this comment.
The result of mallocs are not checked if there is a valid pointer or NULL, which can happen on not enough memory available.
lazedo
force-pushed
the
dbtext-fixes-master
branch
from
8b017cc
to
af1d161
Compare
|
Thanks, it can be merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.