app_perl: Make sv2int_str() static #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you update the commit message to follow the recommendations from contributions guide? The commit messages are used to generate the changelog and it is good to have a coherence there. |
jhcloos
changed the title
- The function is only called from the xs file, and C11’s inline semantics mean that gcc-5 and later miscompile this file when no optimization is specified. Signed-off-by: James Cloos <cloos@jhcloos.com>
|
Re-submitting. |
|
Github didn’t bother to email me your comment; I just happened on it today. The current tip of https://github.com/jhcloos/kamailio.git master has the updated commit. I can’t tell whether this web ui is doing the right thing.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function is only called from the xs file, and C11’s inline
semantics mean that gcc-5 and later miscompile this file when
no optimization is specified.
Signed-off-by: James Cloos cloos@jhcloos.com