Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uri_db: rework the possibiltiy to use any sip uri #1034

Merged
merged 4 commits into from Mar 27, 2017

Conversation

dunst0
Copy link
Contributor

@dunst0 dunst0 commented Mar 15, 2017

Adding the possibility to check any sip uri against the uri_db table and updates the log macros from LM_ to the new ones.

@dunst0 dunst0 changed the title uri_db: add the possibiltiy to use any sip uri and log macros updates uri_db: rework the possibiltiy to use any sip uri and log macros updates Mar 15, 2017
@miconda
Copy link
Member

miconda commented Mar 15, 2017

The commits for new features should not be mixed with changes for formatting or renaming of functions/macros in existing code, because it is not easy to review what are the actual new additions. Please rework the changes and make a commit dedicated only to the new feature.

Moreover, LM_* macros are also new ones that prefix the log messages with function name, etc... no need to change those macros at all. If we decide to replace/remove them, then it will be easier to do substituttion on a LM_XYZ than on XYZ.

@dunst0
Copy link
Contributor Author

dunst0 commented Mar 15, 2017

Thanks for the remarks, I will rework the changes.

@dunst0 dunst0 changed the title uri_db: rework the possibiltiy to use any sip uri and log macros updates uri_db: rework the possibiltiy to use any sip uri Mar 23, 2017
@dunst0
Copy link
Contributor Author

dunst0 commented Mar 23, 2017

@miconda hope it is Ok how I did the changes you asked for.

@miconda
Copy link
Member

miconda commented Mar 27, 2017

Thanks!

@miconda miconda merged commit fbe1ed2 into kamailio:master Mar 27, 2017
@dunst0 dunst0 deleted the feature/uri_db_extention branch March 28, 2017 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants