ndb_redis: add pipeline suppport for REDIS Module #1079
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging Carsten (@ngvoice) -- is it needed to wait for fixing the changes done by using shm memory or this PR can be merged? |
claudiupb
force-pushed
the
redis_pipeline
branch
from
71c86f7
to
0a0ac0e
Compare
|
@claudiupb - can you resolve the conflicts so this PR can be merged? The module was in a broken state at the time you did the PR, which needed to be fixed, sorry for the extra work. |
|
Ok, I will resolve the conflicts |
|
I resolved the conflicts in the PR. |
|
@claudiupb - the travis-ci is reporting compilation errors with the patches, see the details from travis ci checks (next comment). |
|
Hello, there was a problem because _redisc_srv_list type was modified. The problem if fixed now |
|
Thanks, I merged it manually to get rid of the extra commit messages that didn't follow the required format -- commit ff8cfa6 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have added pipeline support to the ndb_redis_module. Two functions are added:
-redis_pipe_cmd which appends a command to be pipelined(syntax is identical with redis_cmd)
-redis_execute which sends one message with all existing pipelined commands and handles the replies
To send multiple commands in a single message, the user must call redis_pipe_cmd for each command, and then redis_execute to send all messages.
This enhancement is not compatible with the recently added REDIS cluster support, so if that is enabled the new functions don't do anything but log an error.
Thanks,
Claudiu Boriga