Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xmlrpc: add <value> tag to array elements #1183

Merged
merged 1 commit into from Jul 11, 2017
Merged

xmlrpc: add <value> tag to array elements #1183

merged 1 commit into from Jul 11, 2017

Conversation

albertored
Copy link
Contributor

@albertored albertored commented Jul 11, 2017 •
edited

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

As XML-RPC specification says

An <array> contains a single <data> element, which can contain any number of <value>s.

Before this PR the function rpc_array_add adds elements to the <data> tag without wrapping them in <value> tag.

See http://xmlrpc.scripting.com/spec.html

@albertored
xmlrpc: add <value> tag to array elements
cfc6e36 
- add call to `add_xmlrpc_reply(reply, &value_prefix)` to  `rpc_array_add` function
- add call to `add_xmlrpc_reply(reply, &value_suffix)` to  `rpc_array_add` function
@miconda
Copy link
Member

miconda commented Jul 11, 2017

Thanks!

@miconda miconda merged commit 5f83e70 into kamailio:master Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@albertored @miconda