Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make get_hdr_by_name/next_sibling_hdr_by_name case insensitive #1217

Closed
wants to merge 1 commit into from
Closed

make get_hdr_by_name/next_sibling_hdr_by_name case insensitive #1217

wants to merge 1 commit into from

Conversation

nevian427
Copy link

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

core: make get_hdr_by_name/next_sibling_hdr_by_name case insensitive

  • Credits goes to Alexandr Dubovikov

@miconda
Copy link
Member

miconda commented Aug 16, 2017

The commit message doesn't have the format required by the contributing guide, although you have checked that box. Amend the commit message accordingly:

@miconda miconda closed this Aug 16, 2017
@miconda miconda reopened this Aug 16, 2017
@nevian427
Copy link
Author

Sorry what's wrong? Looks like formatted right. Or should I elaborate in desc why this fix is required?

@miconda
Copy link
Member

miconda commented Aug 16, 2017

See the commit message as it appears in the patch:

What you had as Description in PR comment is not in the commit message.

@nevian427
Copy link
Author

I see thanks. I thought Description was commit message :(
So I must make new commit from scratch, right?

@miconda
Copy link
Member

miconda commented Aug 16, 2017

The commit message is the one you give when doing "git commit ...".

The patch is small, so probably is faster to use the diff (https://github.com/kamailio/kamailio/commit/b84d4a1f09b6310522ac83546a7a34b2c52f0ecf.diff), make a fresh clone of kamailio repo and do the commit again, with a new PR.

Otherwise, you can search on the web how to amend a commit message, but can take some time to sort out when the commit was pushed remote.

miconda added a commit that referenced this pull request Aug 17, 2017
@miconda
core: parser - use case insensitive comparison to get header by name
4072b0f 
- same for next sibling header
- GH #1217
@miconda
Copy link
Member

miconda commented Aug 17, 2017

Pushed patch with a manual commit.

@miconda miconda closed this Aug 17, 2017
miconda added a commit that referenced this pull request Aug 30, 2017
@miconda
core: parser - use case insensitive comparison to get header by name
672ea36 
- same for next sibling header
- GH #1217

(cherry picked from commit 4072b0f)
miconda added a commit that referenced this pull request Feb 22, 2018
@miconda
core: parser - use case insensitive comparison to get header by name
ae94a11 
- same for next sibling header
- GH #1217

(cherry picked from commit 4072b0f)
(cherry picked from commit 672ea36)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nevian427 @miconda