pv: add string corehash transform #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optional size parameter to return the slot if supplied
example $(var(myvar){s.corehash}) returns the hash
$(var(myvar){s.corehash, 32}) returns the slot
|
Thanks! |
|
I merged, then pushed some adjustments. What I noticed is that the value is returned as a string, while one may expect a number, given that's typically an hash id. Any particular reason for this? |
|
@miconda thanks. the reason was for large numbers not handled properly in script (uint) afaik. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type Of Change
Checklist:
Description
adds string transform with optional size parameter to return the slot if supplied
usagereturns the hashreturns the slotwould be great if this can be backported to branch 5.0 and included in next week release