Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/kamailio/centos: Updated RPM spec file to support build fedora, RHEL, openSUSE #1227

Closed
wants to merge 2 commits into from

Conversation

sergey-safarov
Copy link
Member

Updated RPM spec file to support build fedora, RHEL, openSUSE via openSUSE build service.
Removed unnecessary RPM spec files

@sergey-safarov
Copy link
Member Author

Using this RPM spec file created packages for Fedora, CentOS, RHEL, OpenSUSE distrs
more info

@miconda
Copy link
Member

miconda commented Sep 4, 2017

Is this PR removing old specs and adds the one for OpenSuse Build Service (OBS)?

@sergey-safarov
Copy link
Member Author

Yes. Now one SPEC file for all RPM based dists.
Old SPEC is removed.

@miconda
Copy link
Member

miconda commented Sep 4, 2017

As far as I understood, at least it was the case in the past, those %if in OBS were extensions of OBS, not working on usual rpm build. That's the reason I did OBS specs only in the OBS repo, not in Kamailio repo.

So I would rather keep the old specs as they are for those that want to build locally and have obs folder to host the specs for the suse build service. Later, if proves to be ok to use the obs spec for building locally on the rpm distros (centos, fedora, redhat, oracle, ...), then we can either make symlinks or remove the specific folder.

Therefore, you should make a PR just for inclusion of the OBS spec files. Removal of the others will be subject of further discussions in the community.

@miconda
Copy link
Member

miconda commented Sep 4, 2017

Btw, there has to be a PR for master branch first. Then one to backport to 5.0.

@sergey-safarov
Copy link
Member Author

Created PR #1228

@miconda miconda closed this Sep 4, 2017
@sergey-safarov sergey-safarov deleted the spec_update-50 branch December 12, 2018 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants