Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ims_registrar_pcscf: Add support for sec-agree parameters parsing #1238

Merged
merged 1 commit into from Sep 20, 2017

Conversation

tdimitrov
Copy link
Contributor

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

In nutshell, this PR adds support for sec-agree parameters parsing in PCSCF.

ims_usrloc_pcscf can store security related parameters from sec-agree extension. However ims_register_pcscf doesn't parse the corresponding SIP headers. This PR adds code, which parses security-client header fields and stores them via ims_usrloc_pcscf.

@miconda
Copy link
Member

miconda commented Sep 20, 2017

Thanks for contribution! Hopefully @ngvoice or @jaybeepee have time to check a bit before merging.

@ngvoice ngvoice merged commit 0c47c62 into kamailio:master Sep 20, 2017
@ngvoice
Copy link
Member

ngvoice commented Sep 20, 2017

Thanks! Looks okay!

@tdimitrov tdimitrov deleted the sec-agree branch September 20, 2017 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants