Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: removing the condition for second record_route ipv6 header #1315

Closed
wants to merge 1 commit into from
Closed

core: removing the condition for second record_route ipv6 header #1315

wants to merge 1 commit into from

Conversation

surendratiwari3
Copy link
Contributor

@surendratiwari3 surendratiwari3 commented Nov 15, 2017 •
edited

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

when we are sending the call from ipv6 tls registered endpoint to kamailio and kamailio use the dispatcher module to forward that call to tcp sip server then second record route header have ipv6 address without [].so another sip server is saying 400 bad record route header.
before (with error):
Record-Route: sip:2600:1F1C:74E:E100:E89F:BEB1:10AF:1CB1:5060;transport=tcp;r2=on;lr=on;ftag=msDr8yzIe5obR7fSfD-jPiJPFcJoVwwr;did=ae1.8861

after (correct):
Record-Route: sip:[2600:1F1C:74E:E100:E89F:BEB1:10AF:1CB1]:5060;transport=tcp;r2=on;lr=on;ftag=msDr8yzIe5obR7fSfD-jPiJPFcJoVwwr;did=ae1.8861

@surendratiwari3 surendratiwari3 mentioned this pull request Nov 15, 2017
Closed
@surendratiwari3
Copy link
Contributor Author

@miconda please review this also for record_route header

@miconda
Copy link
Member

miconda commented Nov 17, 2017

Do you have advertise address to the listen socket?

miconda added a commit that referenced this pull request Nov 17, 2017
@miconda
core: test if ipv6 address starts with [ for subst snd lumps
2cb94f2 
- safer than the test against cached socket address known to be without
[], allowing to pass any address value to be used
- reported by GH #1315
@miconda
Copy link
Member

miconda commented Nov 17, 2017

I just pushed another patch (referenced above), because there were other cases when the same condition was used. The new patch is taking a safer path by checking if the ipv6 address starts with [.

Can you test and report if ok?

@surendratiwari3
Copy link
Contributor Author

@miconda yes ,i have advertise address to the listen socket.

@surendratiwari3
Copy link
Contributor Author

@miconda i will test the same.we are expecting all ipv6 patch to be merged with stable branch so we can start using those only.

@miconda
Copy link
Member

miconda commented Nov 17, 2017

If testing with master is ok, then I will backport. Just report if it works fine or not.

@surendratiwari3
Copy link
Contributor Author

@miconda i tested with master branch.its working fine.it will be good if you can commit all changes related to ipv6 to all stable releases specially to 5.x.x branches.reference to following pull request:
#1319
#1315
#1291

miconda added a commit that referenced this pull request Nov 21, 2017
@miconda
core: test if ipv6 address starts with [ for subst snd lumps
69fb3b9 
- safer than the test against cached socket address known to be without
[], allowing to pass any address value to be used
- reported by GH #1315

(cherry picked from commit 2cb94f2)
miconda added a commit that referenced this pull request Nov 21, 2017
@miconda
core: test if ipv6 address starts with [ for subst snd lumps
e23a4d1 
- safer than the test against cached socket address known to be without
[], allowing to pass any address value to be used
- reported by GH #1315

(cherry picked from commit 2cb94f2)
(cherry picked from commit 69fb3b9)
@miconda
Copy link
Member

miconda commented Nov 22, 2017

Patches should be backported by now in the 5.x.x branches, if you still find an issue, open another item on the tracker.

@miconda miconda closed this Nov 22, 2017
@SurendraPlivo
Copy link

SurendraPlivo commented Nov 22, 2017 •
edited

@miconda thanks.let us know once patches related to ipv6 are backported to all 5.x.x branches.

miconda added a commit that referenced this pull request Feb 22, 2018
@miconda
core: test if ipv6 address starts with [ for subst snd lumps
5b5ea4a 
- safer than the test against cached socket address known to be without
[], allowing to pass any address value to be used
- reported by GH #1315

(cherry picked from commit 2cb94f2)
(cherry picked from commit 69fb3b9)
(cherry picked from commit e23a4d1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@surendratiwari3 @miconda @SurendraPlivo