Patches to the KEMI framework exports #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Mismatch between export and function declaration with regards to the quantity of parameters
- Mismatch between export and function declaration with regards to the quantity of parameters
- Updating which function KEMI function allow_address actually calls upon
…ctions - Mismatch between export and function declaration with regards to the quantity of parameters
…nctions - Mismatch between export and function declaration with regards to the quantity of parameters
…ions - Mismatch between export and function declaration with regards to the quantity of parameters
…tions - Mismatch between export and function declaration with regards to the quantity of parameters
- Updating the name to reflect the original name. Mismatch between export and function declaration with regards to the type of parameters.
- Since constants are used as arguments on the called function I suppose the parameters are not necessary on the parent function
- Mismatch between export and function declaration with regards to the quantity of parameters
- Mismatch between export and function declaration with regards to the quantity of parameters
- Utilize same formatting as all other KEMI exports
…ctions - Mismatch between export and function declaration with regards to the quantity of parameters
|
Many thanks! Saved me a lot of time going through again and proof-checking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
in
doc/subfolder, the README file is autogenerated)Type Of Change
Checklist:
Description
Updated some issues I found in the KEMI exports while reviewing the implementation. There is some name change there hence the breaking change.