Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/kamailio/deb: add http_async to kamailio-extra-modules [skip ci] #1375

Closed
wants to merge 2 commits into from

Conversation

btriller
Copy link
Contributor

@btriller btriller commented Dec 18, 2017

(cherry picked from commit 72daa18)

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

@miconda
Copy link
Member

miconda commented Dec 20, 2017

The name of the module is http_async_client, the modules group is named http_async. These need to be reflected properly -- in some parts of the changes, there are module names, not module group names.

@btriller
Copy link
Contributor Author

in some parts of the changes, there are module names, not module group names.

@miconda Are you referring to the descriptions in the control files? I'd then submit another pull request to master and backport that to active branches, if you agree.

@linuxmaniac
Copy link
Member

I did the necessary cherry-picks manually. Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants