Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app_lua: LUAJIT variable to build agains LuaJIT compiler #1384

Merged
merged 3 commits into from Dec 22, 2017

Conversation

vhernando
Copy link
Contributor

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

Added LUAJIT variable to build app_lua module against LuaJIT compiler (version 5.1). If this variable is not set users still build app_lua module against standard Lua.

E.g: $ LUAJIT="yes" make modules modules=modules/app_lua # Build against LuaJIT
$ make modules modules=modules/app_lua # Build against standard Lua.

(Warning: LuaJIT version is 5.1 so scripts prepared for higher Lua versions may not work with LuaJIT)

@miconda
Copy link
Member

miconda commented Dec 22, 2017

This can be merged, but a note about this compile option and the constraint with luajit version has to be added to the docs of the module.

@miconda
Copy link
Member

miconda commented Dec 22, 2017

For future reference, you do not have to generate the README anymore, it is generated automatically by the server couple of minutes after pushing the commit to xml file.

@miconda miconda merged commit 1a1605e into master Dec 22, 2017
@miconda miconda deleted the app_lua_luajit branch January 28, 2018 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants