Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acc: Allow nullable cdr extra fields #1385

Merged
merged 1 commit into from Jan 2, 2018

Conversation

cruzccl
Copy link
Contributor

@cruzccl cruzccl commented Dec 22, 2017

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

Description

  • allow custom cdr fields defined with cdr_extra modparam to be saved
    as null. Before this change, cdr_extra variables not defined in config
    operation (or set to $null) were saved as empty string (''). This commit makes
    possible to save them as NULL value.

  • new modparam to make this behaviour configurable: cdr_extra_nullable.
    Set it to 1 to enable this new behaviour (default value: 0)

- allow custom cdr fields defined with cdr_extra modparam to be saved
  as null. Before this change, cdr_extra variables not defined in config
  operation (or set to $null) were saved as empty string (''). This commit makes
  possible to save them as NULL value.

- new modparam to make this behaviour configurable: cdr_extra_nullable.
  Set it to 1 to enable this new behaviour (default value: 0)
@miconda
Copy link
Member

miconda commented Jan 2, 2018

Thanks!

@miconda miconda merged commit d425a89 into kamailio:master Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants