Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ims_usrloc_scscf: missing assignment of record_route #1410

Merged
merged 1 commit into from Jan 25, 2018
Merged

ims_usrloc_scscf: missing assignment of record_route #1410

merged 1 commit into from Jan 25, 2018

Conversation

christoph-v
Copy link
Contributor

In update_subscriber() function, when the rs is assigned to the subs,
it is missing the record_route component, which leads to core dump in
some scenarios.

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

Without this bugfix, a core dump can happen during SIP REGISTER in S-CSCF.
Reason: the record_route component was forgotten to be assigned when assigning rs to Subs in the update_subscriber() function.
This assignment was added.

In update_subscriber() function, when the rs is assigned to the subs,
it is missing the record_route component, which leads to core dump in
some scenarios.
@ngvoice ngvoice merged commit 97fd110 into kamailio:master Jan 25, 2018
@christoph-v christoph-v deleted the missing_record_route_assignment branch January 30, 2018 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants