Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

textops: properly initialize new tr_param_t object #1506

Closed
wants to merge 1 commit into from

Conversation

lyokha
Copy link
Contributor

@lyokha lyokha commented Apr 24, 2018

Just memset() this to 0.

Without this kamailio segfaults when running fparam_free_restore() on a variable that contains transformations immediately after creation, because field next of the transformation contains garbage.

In my case this was variable which contained re.subst transformation. And below is the top of the backtrace.

#0  0x00000000005cba17 in tr_param_free (tp=0x292873257325203a) at core/pvapi.c:1804
#1  0x00000000005cb677 in tr_destroy (t=0x7f6387ed0c40) at core/pvapi.c:1742
#2  0x00000000005cb9c1 in tr_free (t=0x0) at core/pvapi.c:1786
#3  0x00000000005ca194 in pv_spec_destroy (spec=0x7f6387ed0b80) at core/pvapi.c:1570
#4  0x00000000005ca1b7 in pv_spec_free (spec=0x7f6387ed0b80) at core/pvapi.c:1578
#5  0x0000000000541820 in fparam_free_contents (fp=0x7f6387ed0ae0) at core/sr_module.c:1334
#6  0x0000000000541898 in fparam_free_restore (param=0x7f6387ed1168) at core/sr_module.c:1364

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

without this kamailio segfaults when running fparam_free_restore() on
such an object immediately after creation, because its field "next"
contains garbage
@miconda
Copy link
Member

miconda commented Apr 24, 2018

Thanks! Applied it manually because the git log message was not properly using module prefix, only the pull request was with the title like it should have been the git log.

@miconda miconda closed this Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants