Replaced working with bson utf8 string inside db_mongodb_convert_bson function #1508
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
in
doc/
subfolder, the README file is autogenerated)Type Of Change
Checklist:
Description
During query operations string fields inside result structure db1_res_t could be corrupted because of incorrect usage of bson memory.
This issue is reproduced when we need to read more than 150 documents from the database.
Firstly bson_iter_utf8 function returns pointer to memory which is allocated by bson library. It looks like this memory is used multiple times (some kind of circular buffer). So the data must be copied into Kamailio memory instead storing that pointer. The original pointer becomes invalid after some time.
Secondly, this pointer must not be freed by the caller of bson_iter_utf8. At the current version bson allocated pointer is freed by Kamailio function pkg_free like it is was allocated by pkg_malloc.