New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added RURI-pattern matching and priority #152
Conversation
Hello, |
Master branch will be frozen again after at least 6 months, plenty of time to get new features in v4.4. The patch got big because you changed the order of existing columns, not adding new column as last one, but inserting in between, so it was not trivial to analyze quickly when I tried a while ago as I found a bit of spare time. Most likely I can allocate some time next week, as v4.3 will be out this week. |
Thank you for the response. |
Some comments:
|
Add the changes to the db schema -- you have to update the xml file in lib/srdb1/schema/. |
And extend the documentation of the module with the appropriate description and new parameters -- changes have to be done to xml files in modules/permissions/doc/ |
Hello, |
The commit message is not relevant for the all changes done by the patch, but reflects the last operation you did as per comments in this discussion. It is not suitable for the log of source code changes history. I will apply the patch manually this time if all ok with the review. But for the future be sure you follow the guidelines for commit messages from: Note also that you can have many commits in the same pull request. No need to rework a new patch always, you can add another patch to complete the changes done with previous patches. |
Hello, |
I applied the patch manually, split in few commits, per components. The diff for each commit is available also on github, at: Add .diff to the commit path. I fixed the upgrade of table version for trusted. You have to make a new pull request to update the docs regarding the priority, to specify what kind of value represents higher priority. |
Hello,
This pull request adds 2 features.
--Prioritize the trusted records (highest to lowest priority)
--Match from-uri AND request-uri, if either is blank only one is matched.
Please review the pull request and let me know if any other changes are needed.
Thank you.
Emmanuel