tm: add relay_100 config parameter to support stateless operation #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi,
What is the purpose of this feature? 100 Trying replies are
hop-by-hop...
…On Wed, May 16, 2018 at 07:53:51AM -0700, Armen Babikyan wrote:
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
#1534
-- Commit Summary --
* tm: add relay_100 config parameter to support stateless operation
-- File Changes --
M src/modules/tm/config.c (5)
M src/modules/tm/config.h (1)
M src/modules/tm/t_reply.c (2)
M src/modules/tm/tm.c (1)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1534.patch
https://github.com/kamailio/kamailio/pull/1534.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#1534
_______________________________________________
Kamailio (SER) - Development Mailing List
***@***.***
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
--
Alex Balashov | Principal | Evariste Systems LLC
Tel: +1-706-510-6800 / +1-800-250-5920 (toll-free)
Web: http://www.evaristesys.com/, http://www.csrpswitch.com/
|
miconda
reviewed
May 24, 2018
src/modules/tm/t_reply.c
Outdated
| @@ -1494,7 +1494,7 @@ static enum rps t_should_relay_response( struct cell *Trans , int new_code, | |||
| #endif | |||
| /* 1xx and 2xx except 100 will be relayed */ | |||
| Trans->uac[branch].last_received=new_code; | |||
| *should_relay= new_code==100? -1 : branch; | |||
| *should_relay= (new_code=100 && !cfg_get(tm, tm_cfg, relay_100)) ? -1 : branch; | |||
There was a problem hiding this comment.
Should it still be new_code==100 in the condition or I am missing something?
|
The last sentence of RFC3261 Section 21.1.1 implicitly suggests that it is valid behavior to forward 100 Trying when operating stateless mode, which is which this change aims to allow. I've also updated documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
in
doc/subfolder, the README file is autogenerated)Type Of Change
Checklist:
Description