Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix trash expires #1539

Merged
merged 1 commit into from May 24, 2018
Merged

Bugfix trash expires #1539

merged 1 commit into from May 24, 2018

Conversation

christoph-v
Copy link
Contributor

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally against Version 5.1.0
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

When old (maybe forgotten) Contacts expire in S-CSCF, then current - wanted - calls will be deleted, which is not wanted. Reason is the usage of "=" Operator instead "==" Operator in ims_usrloc_scscf module.

@linuxmaniac
Copy link
Member

@christoph-v can you please send this change as one commit, please. git rebase -i origin/master and git push --force are your friends

ims_usrloc_scscf: bugfix Contct is removed when old Contct expires
2b1e895 
in function unlink_contact_from_impu() (in file impurecord.c) an
assignment "=" is used instead of a comparision operator "==". This
leads to mess, when old contact expires.
@christoph-v
Copy link
Contributor Author

christoph-v commented May 22, 2018 •
edited

Should be reduced to one commit, now. Please try again, @linuxmaniac

SurendraPlivo
SurendraPlivo reviewed May 24, 2018
View reviewed changes
Copy link

@SurendraPlivo SurendraPlivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you tested those changes ?

@miconda miconda requested review from ngvoice and removed request for jaybeepee May 24, 2018 06:27
@miconda
Copy link
Member

miconda commented May 24, 2018

@ngvoice - any comment on this change? It looks like a simple fix, but better to have a second review on it.

@ngvoice ngvoice merged commit c2fd44b into kamailio:master May 24, 2018
@christoph-v
Copy link
Contributor Author

@SurendraPlivo : yes, we tested the fix with following test case:

  1. Register first contact (expires 3600)
  2. Register second contact (expires 120)
  3. Initiate call from first contact
  4. wait a few minutes
  5. Call should NOT be torn down by S-CSCF, when second contact expires (without fix, it IS)
  6. send bye, end the test case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SurendraPlivo SurendraPlivo SurendraPlivo left review comments

@ngvoice ngvoice Awaiting requested review from ngvoice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@christoph-v @linuxmaniac @miconda @SurendraPlivo @ngvoice