Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app_python3: fix kemi function call argument type checks #1568

Merged
merged 1 commit into from Jun 22, 2018

Conversation

kmduk
Copy link
Contributor

@kmduk kmduk commented Jun 19, 2018

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

The kemi function argument type checks before the arguments are extracted from the python tuple were not strict enough, resulting in the wrong value being passed to the functions.

@miconda miconda requested a review from aalba6675 June 19, 2018 16:57
@miconda
Copy link
Member

miconda commented Jun 19, 2018

@kmduk - thanks, can you check and make also a PR for app_python if it needs support for nsss functions?

@aalba6675
Copy link
Contributor

LGTM

@miconda miconda merged commit 3c4bc85 into kamailio:master Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants